Commit 8ecc9d09 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

[iOS] Fix the identity disk position

This CL fixes the position of the identity disk (by fixing the position
of the invisible toolbar). The constraint was updated when the phone was
rotating, but it was too soon to take into account the safe area.

This CL removes this updates and instead relies on the update from
-updateConstraints as it is called by the CollectionViewController
when its view safe area is updated.

It also removes the implementation of -viewSafeAreaInsetsDidChange
as it is not reliably called.

Fixed: 1041831
Change-Id: I5a8c2681cf91f440ffd50b74dbb537143dcd4495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023889
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735907}
parent 5712233e
......@@ -114,17 +114,11 @@ using base::UserMetricsAction;
if (IsSplitToolbarMode()) {
[self.toolbarDelegate setScrollProgressForTabletOmnibox:1];
}
[self.headerView updateForTopSafeAreaInset:[self topInset]];
};
[coordinator animateAlongsideTransition:transition completion:nil];
}
- (void)viewSafeAreaInsetsDidChange {
[super viewSafeAreaInsetsDidChange];
[self.headerView updateForTopSafeAreaInset:[self topInset]];
}
- (void)dealloc {
[self.accessibilityButton removeObserver:self forKeyPath:@"highlighted"];
}
......@@ -181,6 +175,7 @@ using base::UserMetricsAction;
- (void)updateConstraints {
self.doodleTopMarginConstraint.constant =
content_suggestions::doodleTopMargin(YES, [self topInset]);
[self.headerView updateForTopSafeAreaInset:[self topInset]];
}
- (CGFloat)pinnedOffsetY {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment