Commit 8edb3cb9 authored by pkasting@chromium.org's avatar pkasting@chromium.org

Cleanup: Remove an unnecessary AutocompleteMatch& calculation from

OmniboxEditModel::OpenMatch().

I traced the origin of this weird code back to the days before OpenMatch() took
an AutocompleteMatch; back then, we constructed one so we could get at fields
like |fill_into_edit| that weren't provided to OpenMatch().  Now that we pass
this in, I believe the calculated match should always match the passed-in match.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/47353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232847 0039d316-1c4b-4281-b951-d872f2087c98
parent 2bf4bee7
......@@ -714,8 +714,6 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
if (match.transition == content::PAGE_TRANSITION_KEYWORD) {
// The user is using a non-substituting keyword or is explicitly in
// keyword mode.
const AutocompleteMatch& match = (index == OmniboxPopupModel::kNoMatch) ?
CurrentMatch(NULL) : result().match_at(index);
// Don't increment usage count for extension keywords.
if (delegate_->ProcessExtensionKeyword(template_url, match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment