Commit 8efe4f12 authored by Rouslan Solomakhin's avatar Rouslan Solomakhin Committed by Commit Bot

[Web Payment] More private methods.

Before this patch, the RespondWithCallbacks class in
payment_app_provider_impl.cc contained a number of public methods that
were either not used outside of this class or not used at all.

This patch moves a number of RespondWithCallbacks methods from public to
private and removes one method that was never used.

After this patch, it is more clear which part of RespondWithCallbacks is
used outside of the class.

Bug: 1005076
Change-Id: I1058137899177454cb786a91e16fe7f88dc8eaee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089409
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarDanyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748740}
parent 9a7bc7e6
...@@ -161,6 +161,16 @@ class RespondWithCallbacks : public PaymentHandlerResponseCallback { ...@@ -161,6 +161,16 @@ class RespondWithCallbacks : public PaymentHandlerResponseCallback {
return receiver_.BindNewPipeAndPassRemote(); return receiver_.BindNewPipeAndPassRemote();
} }
void AbortPaymentSinceOpennedWindowClosing(PaymentEventResponseType reason) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId());
service_worker_version_->FinishRequest(request_id_, false);
RespondWithErrorAndDeleteSelf(reason);
}
private:
~RespondWithCallbacks() override = default;
void OnResponseForPaymentRequest( void OnResponseForPaymentRequest(
PaymentHandlerResponsePtr response) override { PaymentHandlerResponsePtr response) override {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId());
...@@ -239,18 +249,6 @@ class RespondWithCallbacks : public PaymentHandlerResponseCallback { ...@@ -239,18 +249,6 @@ class RespondWithCallbacks : public PaymentHandlerResponseCallback {
RespondWithErrorAndDeleteSelf(response_type); RespondWithErrorAndDeleteSelf(response_type);
} }
int request_id() { return request_id_; }
void AbortPaymentSinceOpennedWindowClosing(PaymentEventResponseType reason) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId());
service_worker_version_->FinishRequest(request_id_, false);
RespondWithErrorAndDeleteSelf(reason);
}
private:
~RespondWithCallbacks() override = default;
void ClearCallbackRepositoryAndCloseWindow() { void ClearCallbackRepositoryAndCloseWindow() {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment