Commit 8f71c40c authored by Aleks Totic's avatar Aleks Totic Committed by Commit Bot

[LayoutNG] Fix incorrect DCHECK

Bug: 740993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iec59abf8eef6091655001374be6795aeef87760f
Reviewed-on: https://chromium-review.googlesource.com/1123166
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572088}
parent 17ad5877
......@@ -110,7 +110,6 @@ crbug.com/591099 external/wpt/css/CSS2/normal-flow/block-in-inline-remove-006.xh
crbug.com/591099 external/wpt/css/CSS2/text/white-space-mixed-003.xht [ Pass ]
crbug.com/591099 external/wpt/css/css-backgrounds/box-shadow-syntax-001.xht [ Failure ]
crbug.com/591099 external/wpt/css/css-contain/contain-paint-007.html [ Pass ]
crbug.com/591099 external/wpt/css/css-filter/filtered-inline-is-container.html [ Crash ]
crbug.com/714962 external/wpt/css/css-fonts/font-features-across-space-1.html [ Pass ]
crbug.com/714962 external/wpt/css/css-fonts/font-features-across-space-3.html [ Pass ]
crbug.com/591099 external/wpt/css/css-fonts/font-variant-ligatures-11.html [ Pass ]
......
......@@ -398,8 +398,10 @@ scoped_refptr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(
bool NGOutOfFlowLayoutPart::IsContainingBlockForDescendant(
const NGOutOfFlowPositionedDescendant& descendant) {
EPosition position = descendant.node.Style().GetPosition();
// Descendants whose containing block is inline are always positioned
// inside closest parent block flow.
if (descendant.inline_container) {
DCHECK(position == EPosition::kAbsolute);
return true;
}
return (contains_absolute_ && position == EPosition::kAbsolute) ||
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment