Skip to content

GitLab

T
tangled
Commit 8f7fa53a authored by mathp's avatar mathp Committed by Commit bot
Browse files
Options

[Autofill] Copy attributes for the select elements as well. 

Not setting is_autofilled on select fields results in wrong metrics in FormStructure::LogQualityMetrics.

BUG=512127

Review URL: https://codereview.chromium.org/1245623003

Cr-Commit-Position: refs/heads/master@{#339675}
parent 53c9f701
Hide whitespace changes
Inline Side-by-side
Showing with 100 additions and 67 deletions
chrome/renderer/autofill/form_autofill_browsertest.cc
View file @ 8f7fa53a
...@@ -1563,6 +1563,38 @@ TEST_F(FormAutofillTest, WebFormControlElementToFormFieldSelect) { ...@@ -1563,6 +1563,38 @@ TEST_F(FormAutofillTest, WebFormControlElementToFormFieldSelect) {
EXPECT_EQ(ASCIIToUTF16("Texas"), result3.option_contents[1]); EXPECT_EQ(ASCIIToUTF16("Texas"), result3.option_contents[1]);
} }
// We copy extra attributes for the select field.
TEST_F(FormAutofillTest,
WebFormControlElementToFormFieldSelect_ExtraAttributes) {
LoadHTML("<SELECT id='element' autocomplete='off'/>"
" <OPTION value='CA'>California</OPTION>"
" <OPTION value='TX'>Texas</OPTION>"
"</SELECT>");
WebFrame* frame = GetMainFrame();
ASSERT_NE(nullptr, frame);
WebFormControlElement element = GetFormControlElementById("element");
element.setAutofilled(true);
FormFieldData result1;
WebFormControlElementToFormField(element, EXTRACT_VALUE, &result1);
FormFieldData expected;
expected.name = ASCIIToUTF16("element");
expected.max_length = 0;
expected.form_control_type = "select-one";
// We check that the extra attributes have been copied to |result1|.
expected.is_autofilled = true;
expected.autocomplete_attribute = "off";
expected.should_autocomplete = false;
expected.is_focusable = true;
expected.text_direction = base::i18n::LEFT_TO_RIGHT;
expected.value = ASCIIToUTF16("CA");
EXPECT_FORM_FIELD_DATA_EQUALS(expected, result1);
}
// When faced with <select> field with *many* options, we should trim them to a // When faced with <select> field with *many* options, we should trim them to a
// reasonable number. // reasonable number.
TEST_F(FormAutofillTest, WebFormControlElementToFormFieldLongSelect) { TEST_F(FormAutofillTest, WebFormControlElementToFormFieldLongSelect) {
......
chrome/test/data/autofill/heuristics/output/04_checkout_lowes.com.out
View file @ 8f7fa53a
...@@ -8,11 +8,11 @@ ADDRESS_HOME_LINE2 | address2 | Address Line 2: | | address1_1-default ...@@ -8,11 +8,11 @@ ADDRESS_HOME_LINE2 | address2 | Address Line 2: | | address1_1-default
ADDRESS_HOME_CITY | city | City: | | address1_1-default ADDRESS_HOME_CITY | city | City: | | address1_1-default
ADDRESS_HOME_STATE | state | State: | | address1_1-default ADDRESS_HOME_STATE | state | State: | | address1_1-default
ADDRESS_HOME_ZIP | zipCode | ZIP Code: | | address1_1-default ADDRESS_HOME_ZIP | zipCode | ZIP Code: | | address1_1-default
ADDRESS_HOME_CITY | taxGeoCode | Municipality: As an additional way to make sure you receive your order, we ask that you select the name of your municipality (city, town, borough, village, etc.) followed by the county, township, or parish in which you reside. | | address1_1-default ADDRESS_HOME_CITY | taxGeoCode | Municipality: As an additional way to make sure you receive your order, we ask that you select the name of your municipality (city, town, borough, village, etc.) followed by the county, township, or parish in which you reside. | | taxGeoCode_1-default
UNKNOWN_TYPE | billingAddress | This is also my billing address. | on | address1_1-default UNKNOWN_TYPE | billingAddress | This is also my billing address. | on | taxGeoCode_1-default
EMAIL_ADDRESS | email1 | E-mail Address: | | address1_1-default EMAIL_ADDRESS | email1 | E-mail Address: | | taxGeoCode_1-default
PHONE_HOME_CITY_CODE | billphone1 | Contact Phone: | | address1_1-default PHONE_HOME_CITY_CODE | billphone1 | Contact Phone: | | taxGeoCode_1-default
PHONE_HOME_NUMBER | billphone2 | Contact Phone: | | address1_1-default PHONE_HOME_NUMBER | billphone2 | Contact Phone: | | taxGeoCode_1-default
PHONE_HOME_NUMBER | billphone3 | Contact Phone: | | address1_1-default PHONE_HOME_NUMBER | billphone3 | Contact Phone: | | taxGeoCode_1-default
EMAIL_ADDRESS | selfAddress | Please enter the phone number and e-mail address associated with this billing address.E-mail Address: Contact Phone: | 0 | selfAddress_1-default EMAIL_ADDRESS | selfAddress | Please enter the phone number and e-mail address associated with this billing address.E-mail Address: Contact Phone: | 0 | selfAddress_1-default
UNKNOWN_TYPE | save-address | | on | selfAddress_1-default UNKNOWN_TYPE | save-address | | on | selfAddress_1-default
chrome/test/data/autofill/heuristics/output/08_register_continental.com.out
View file @ 8f7fa53a
...@@ -22,23 +22,23 @@ ADDRESS_HOME_ZIP | ctl00$ContentInfo$Address$zip$txtZip | ZIP/Postal Code: | | ...@@ -22,23 +22,23 @@ ADDRESS_HOME_ZIP | ctl00$ContentInfo$Address$zip$txtZip | ZIP/Postal Code: | |
ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$Address$country$cboCountry | Country: | US | ctl00$CustomerHeader$ddlCountries_1-default ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$Address$country$cboCountry | Country: | US | ctl00$CustomerHeader$ddlCountries_1-default
PHONE_HOME_WHOLE_NUMBER | ctl00$ContentInfo$HomePhone$txtNumber$txtPhone | Home PhoneNumber: | | ctl00$CustomerHeader$ddlCountries_1-default PHONE_HOME_WHOLE_NUMBER | ctl00$ContentInfo$HomePhone$txtNumber$txtPhone | Home PhoneNumber: | | ctl00$CustomerHeader$ddlCountries_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$HomePhone$txtExt$txtPhoneExt | Ext./PIN (optional): | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$HomePhone$txtExt$txtPhoneExt | Ext./PIN (optional): | | ctl00$CustomerHeader$ddlCountries_1-default
ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$HomePhone$cboCountry$cboCountry | Country: | US | ctl00$CustomerHeader$ddlCountries_1-default ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$HomePhone$cboCountry$cboCountry | Country: | US | ctl00$ContentInfo$HomePhone$cboCountry$cboCountry_1-default
PHONE_HOME_WHOLE_NUMBER | ctl00$ContentInfo$BusinessPhone$txtNumber$txtPhone | Business/Other PhoneNumber: | | ctl00$CustomerHeader$ddlCountries_1-default PHONE_HOME_WHOLE_NUMBER | ctl00$ContentInfo$BusinessPhone$txtNumber$txtPhone | Business/Other PhoneNumber: | | ctl00$ContentInfo$HomePhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$BusinessPhone$txtExt$txtPhoneExt | Ext./PIN (optional): | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$BusinessPhone$txtExt$txtPhoneExt | Ext./PIN (optional): | | ctl00$ContentInfo$HomePhone$cboCountry$cboCountry_1-default
ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry | Country: | US | ctl00$CustomerHeader$ddlCountries_1-default ADDRESS_HOME_COUNTRY | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry | Country: | US | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$HomeAirport$txtAirport | Home Airport (optional): | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$HomeAirport$txtAirport | Home Airport (optional): | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
EMAIL_ADDRESS | ctl00$ContentInfo$Email$txtEmail | E-mail Address: | | ctl00$CustomerHeader$ddlCountries_1-default EMAIL_ADDRESS | ctl00$ContentInfo$Email$txtEmail | E-mail Address: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$chkSubOpStatement | | on | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$chkSubOpStatement | | on | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$chkSubopnewsoffers | | on | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$chkSubopnewsoffers | | on | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$chkSubcocomspecials | | on | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$chkSubcocomspecials | | on | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$chkSubtripnotes | | on | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$chkSubtripnotes | | on | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$NewPin$txtNewPin$txtNewPin | New PIN: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$NewPin$txtNewPin$txtNewPin | New PIN: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$NewPin$txtConfPin$txtConfPin | Re-type New PIN: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$NewPin$txtConfPin$txtConfPin | Re-type New PIN: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$username$txtUsername | Username: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$username$txtUsername | Username: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$password$txtPassword | Password: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$password$txtPassword | Password: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$passwordRetype$txtPassword | Re-type Password: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$UsernamePassword$passwordRetype$txtPassword | Re-type Password: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$PINPasswordReminder$PINReminder1$txtPINReminder | PIN Reminder: (cannot include any numbers) | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$PINPasswordReminder$PINReminder1$txtPINReminder | PIN Reminder: (cannot include any numbers) | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$Question$txtSecurity | Security Question: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$Question$txtSecurity | Security Question: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$Answer$txtSecurity | Answer: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$Answer$txtSecurity | Answer: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$AnswerReType$txtSecurity | Re-type Answer: | | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$SecurityQuestionAnswer$AnswerReType$txtSecurity | Re-type Answer: | | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
UNKNOWN_TYPE | ctl00$ContentInfo$txtAgreement | Username and Password (optional)You have the option to create your own easy to remember username or password to sign in to continental.com. The username can be used in place of your OnePass account number and a password can be used in place of your PIN. PIN/Password ReminderIf you forget your PIN or password, we will provide this reminder to access your account.PIN Reminder: (cannot include any numbers)Security Question | Agreement Between User And Continental AirlinesThis Web site is offered to the user conditioned on acceptance by the user ("User") without modification of the terms, conditions, and notices contained herein. By accessing and using this Web site, the User is deemed to have agreed to all such terms, conditions, and notices (the "Agreement").OnePass Terms and ConditionsContinental Airlines and all OnePass partners reserve the right to change any aspect of the OnePass program at any time within 30 days notice to active members. This right includes, but is not limited to, changes in partner affiliation, rules for earning mileage credit and mileage redemption levels. However, rules for use of travel rewards, cities served, flight schedules, limited seating or space availability, restricted travel dates and specific features of promotional offers are subject to change with or without notice at the discretion of Continental Airlines or the OnePass partner. Continental Airlines is not responsible for unilateral action | ctl00$CustomerHeader$ddlCountries_1-default UNKNOWN_TYPE | ctl00$ContentInfo$txtAgreement | Username and Password (optional)You have the option to create your own easy to remember username or password to sign in to continental.com. The username can be used in place of your OnePass account number and a password can be used in place of your PIN. PIN/Password ReminderIf you forget your PIN or password, we will provide this reminder to access your account.PIN Reminder: (cannot include any numbers)Security Question | Agreement Between User And Continental AirlinesThis Web site is offered to the user conditioned on acceptance by the user ("User") without modification of the terms, conditions, and notices contained herein. By accessing and using this Web site, the User is deemed to have agreed to all such terms, conditions, and notices (the "Agreement").OnePass Terms and ConditionsContinental Airlines and all OnePass partners reserve the right to change any aspect of the OnePass program at any time within 30 days notice to active members. This right includes, but is not limited to, changes in partner affiliation, rules for earning mileage credit and mileage redemption levels. However, rules for use of travel rewards, cities served, flight schedules, limited seating or space availability, restricted travel dates and specific features of promotional offers are subject to change with or without notice at the discretion of Continental Airlines or the OnePass partner. Continental Airlines is not responsible for unilateral action | ctl00$ContentInfo$BusinessPhone$cboCountry$cboCountry_1-default
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out
View file @ 8f7fa53a
...@@ -19,22 +19,22 @@ ADDRESS_HOME_STATE | CreditCardInformation.BillingAddressEntry.CAStates_Selected ...@@ -19,22 +19,22 @@ ADDRESS_HOME_STATE | CreditCardInformation.BillingAddressEntry.CAStates_Selected
ADDRESS_HOME_STATE | CreditCardInformation.BillingAddressEntry.MXStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_STATE | CreditCardInformation.BillingAddressEntry.MXStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default
UNKNOWN_TYPE | CreditCardInformation.BillingAddressEntry.OtherStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default UNKNOWN_TYPE | CreditCardInformation.BillingAddressEntry.OtherStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default
ADDRESS_HOME_ZIP | CreditCardInformation.BillingAddressEntry.PostalCode | Zip/Postal Code | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_ZIP | CreditCardInformation.BillingAddressEntry.PostalCode | Zip/Postal Code | | MyWalletInformation.UseMyWalletFunds_1-default
ADDRESS_HOME_COUNTRY | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country Code | 1 | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_COUNTRY | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country Code | 1 | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
PHONE_HOME_WHOLE_NUMBER | CreditCardInformation.BillingPhoneNumberEntry.Number | Phone (with area code) | | MyWalletInformation.UseMyWalletFunds_1-default PHONE_HOME_WHOLE_NUMBER | CreditCardInformation.BillingPhoneNumberEntry.Number | Phone (with area code) | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
UNKNOWN_TYPE | TripInsurance.QuoteID | Yes, add trip protection for a total of $21.00. | 657566350481481886 | MyWalletInformation.UseMyWalletFunds_1-default UNKNOWN_TYPE | TripInsurance.QuoteID | Yes, add trip protection for a total of $21.00. | 657566350481481886 | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
UNKNOWN_TYPE | TripInsurance.QuoteID | No, I choose not to protect my purchase. | 657566350481481887 | MyWalletInformation.UseMyWalletFunds_1-default UNKNOWN_TYPE | TripInsurance.QuoteID | No, I choose not to protect my purchase. | 657566350481481887 | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
CREDIT_CARD_NUMBER | AncillaryCreditCardInformation.BillingCreditCardEntry.CardNumber | Card Number | | MyWalletInformation.UseMyWalletFunds_1-cc CREDIT_CARD_NUMBER | AncillaryCreditCardInformation.BillingCreditCardEntry.CardNumber | Card Number | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-cc
CREDIT_CARD_EXP_MONTH | AncillaryCreditCardInformation.BillingCreditCardEntry.ExpirationMonths_Selected | Expiration* | | MyWalletInformation.UseMyWalletFunds_1-cc CREDIT_CARD_EXP_MONTH | AncillaryCreditCardInformation.BillingCreditCardEntry.ExpirationMonths_Selected | Expiration* | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-cc
CREDIT_CARD_EXP_4_DIGIT_YEAR | AncillaryCreditCardInformation.BillingCreditCardEntry.ExpirationYears_Selected | Expiration* | | MyWalletInformation.UseMyWalletFunds_1-cc CREDIT_CARD_EXP_4_DIGIT_YEAR | AncillaryCreditCardInformation.BillingCreditCardEntry.ExpirationYears_Selected | Expiration* | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-cc
CREDIT_CARD_NAME | AncillaryCreditCardInformation.BillingCreditCardEntry.CardPersonName | Name on Card | | MyWalletInformation.UseMyWalletFunds_1-cc CREDIT_CARD_NAME | AncillaryCreditCardInformation.BillingCreditCardEntry.CardPersonName | Name on Card | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-cc
ADDRESS_HOME_COUNTRY | AncillaryCreditCardInformation.BillingAddressEntry.Countries_Selected | Country | US | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_COUNTRY | AncillaryCreditCardInformation.BillingAddressEntry.Countries_Selected | Country | US | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_LINE1 | AncillaryCreditCardInformation.BillingAddressEntry.Address1 | Address | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_LINE1 | AncillaryCreditCardInformation.BillingAddressEntry.Address1 | Address | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_LINE2 | AncillaryCreditCardInformation.BillingAddressEntry.Address2 | Address Line 2 | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_LINE2 | AncillaryCreditCardInformation.BillingAddressEntry.Address2 | Address Line 2 | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_CITY | AncillaryCreditCardInformation.BillingAddressEntry.City | City | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_CITY | AncillaryCreditCardInformation.BillingAddressEntry.City | City | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.USStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.USStates_Selected | State/Province | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.CAStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.CAStates_Selected | State/Province | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.MXStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_STATE | AncillaryCreditCardInformation.BillingAddressEntry.MXStates_Selected | State/Province | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
UNKNOWN_TYPE | AncillaryCreditCardInformation.BillingAddressEntry.OtherStates_Selected | State/Province | | MyWalletInformation.UseMyWalletFunds_1-default UNKNOWN_TYPE | AncillaryCreditCardInformation.BillingAddressEntry.OtherStates_Selected | State/Province | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_ZIP | AncillaryCreditCardInformation.BillingAddressEntry.PostalCode | Zip/Postal Code | | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_ZIP | AncillaryCreditCardInformation.BillingAddressEntry.PostalCode | Zip/Postal Code | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
ADDRESS_HOME_COUNTRY | AncillaryCreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country Code | 1 | MyWalletInformation.UseMyWalletFunds_1-default ADDRESS_HOME_COUNTRY | AncillaryCreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country Code | 1 | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
PHONE_HOME_WHOLE_NUMBER | AncillaryCreditCardInformation.BillingPhoneNumberEntry.Number | Phone (with area code) | | MyWalletInformation.UseMyWalletFunds_1-default PHONE_HOME_WHOLE_NUMBER | AncillaryCreditCardInformation.BillingPhoneNumberEntry.Number | Phone (with area code) | | CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected_1-default
chrome/test/data/autofill/heuristics/output/20_register_alaskaair.com.out
View file @ 8f7fa53a
...@@ -23,17 +23,17 @@ ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateCA | Canadian Provinc ...@@ -23,17 +23,17 @@ ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateCA | Canadian Provinc
ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateMX | Mexican States | | FormUserControl$_guardianInformation$_lastName$_name_1-default ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateMX | Mexican States | | FormUserControl$_guardianInformation$_lastName$_name_1-default
ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateXX | State/Province Other | | FormUserControl$_guardianInformation$_lastName$_name_1-default ADDRESS_HOME_STATE | FormUserControl$_mailingAddress$_stateXX | State/Province Other | | FormUserControl$_guardianInformation$_lastName$_name_1-default
ADDRESS_HOME_ZIP | FormUserControl$_mailingAddress$_zip | Zip/Postal Code* | | FormUserControl$_guardianInformation$_lastName$_name_1-default ADDRESS_HOME_ZIP | FormUserControl$_mailingAddress$_zip | Zip/Postal Code* | | FormUserControl$_guardianInformation$_lastName$_name_1-default
ADDRESS_HOME_COUNTRY | FormUserControl$_contactInformation$_phoneNumber$_countryCode | Country Code | 1 | FormUserControl$_guardianInformation$_lastName$_name_1-default ADDRESS_HOME_COUNTRY | FormUserControl$_contactInformation$_phoneNumber$_countryCode | Country Code | 1 | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
PHONE_HOME_WHOLE_NUMBER | FormUserControl$_contactInformation$_phoneNumber$_phoneNumberTextBox | Country Code | | FormUserControl$_guardianInformation$_lastName$_name_1-default PHONE_HOME_WHOLE_NUMBER | FormUserControl$_contactInformation$_phoneNumber$_phoneNumberTextBox | Country Code | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_contactInformation$_phoneNumber$_extensionTextBox | Ext. | | FormUserControl$_guardianInformation$_lastName$_name_1-default UNKNOWN_TYPE | FormUserControl$_contactInformation$_phoneNumber$_extensionTextBox | Ext. | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
EMAIL_ADDRESS | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox | Email Address* | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default EMAIL_ADDRESS | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox | Email Address* | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_userIdPassword$_userId$_userId | Create a User ID* | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_userIdPassword$_userId$_userId | Create a User ID* | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_userIdPassword$_password$_password | Create a Password | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_userIdPassword$_password$_password | Create a Password | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_userIdPassword$_reEnterPassword$_password | Re-enter Password | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_userIdPassword$_reEnterPassword$_password | Re-enter Password | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_secretQuestion$_question | Secret Question* | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_secretQuestion$_question | Secret Question* | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_secretQuestion$_answer | Please choose a secret question and provide the answer. You will need to answer the question again in case you forget your password. Make sure you choose a question and answer that are easy for you to remember, but difficult for other people to know.Secret Question* Answer* | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_secretQuestion$_answer | Please choose a secret question and provide the answer. You will need to answer the question again in case you forget your password. Make sure you choose a question and answer that are easy for you to remember, but difficult for other people to know.Secret Question* Answer* | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_insiderNewsletter$_subscriptionCheckBox | Insider NewsletterA weekly email personalized to provide you with an insider glimpse of the best deals we have to offer - across the board. | on | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_insiderNewsletter$_subscriptionCheckBox | Insider NewsletterA weekly email personalized to provide you with an insider glimpse of the best deals we have to offer - across the board. | on | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
ADDRESS_HOME_CITY | FormUserControl$_subscriptionsOffers$_primaryDepartureCity$_primaryDepartureCity$_city | Primary Departure City | | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default ADDRESS_HOME_CITY | FormUserControl$_subscriptionsOffers$_primaryDepartureCity$_primaryDepartureCity$_city | Primary Departure City | | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_eStatements$_subscriptionCheckBox | Mileage Plan E-Statements and Partner OffersA monthly recap of your Mileage Plan activity along with program news, exclusive partner offers, and countless ways to earn free travel faster. | on | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_eStatements$_subscriptionCheckBox | Mileage Plan E-Statements and Partner OffersA monthly recap of your Mileage Plan activity along with program news, exclusive partner offers, and countless ways to earn free travel faster. | on | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_asQXAnnouncements$_subscriptionCheckBox | Alaska AnnouncementsOccasional email that puts you "in the know" about sales, promotions, and other important travel information. | on | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_subscriptionsOffers$_asQXAnnouncements$_subscriptionCheckBox | Alaska AnnouncementsOccasional email that puts you "in the know" about sales, promotions, and other important travel information. | on | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
UNKNOWN_TYPE | FormUserControl$_mpTermsAndConditions$_iAgree | Mileage Plan™ Terms & Conditions* I acknowledge that I have reviewed these Mileage Plan Terms and Conditions | on | FormUserControl$_contactInformation$_emailAddress$_emailAddressTextBox_1-default UNKNOWN_TYPE | FormUserControl$_mpTermsAndConditions$_iAgree | Mileage Plan™ Terms & Conditions* I acknowledge that I have reviewed these Mileage Plan Terms and Conditions | on | FormUserControl$_contactInformation$_phoneNumber$_countryCode_1-default
chrome/test/data/autofill/heuristics/output/25_checkout_m_llbean.com.out
View file @ 8f7fa53a
...@@ -4,13 +4,13 @@ NAME_MIDDLE | _1_middleName | Middle Name(optional) | | _1_personTitle_1-defaul ...@@ -4,13 +4,13 @@ NAME_MIDDLE | _1_middleName | Middle Name(optional) | | _1_personTitle_1-defaul
NAME_LAST | _1_lastName | Last Name | | _1_personTitle_1-default NAME_LAST | _1_lastName | Last Name | | _1_personTitle_1-default
UNKNOWN_TYPE | _1_gender | Male | M | _1_personTitle_1-default UNKNOWN_TYPE | _1_gender | Male | M | _1_personTitle_1-default
UNKNOWN_TYPE | _1_gender | Female | F | _1_personTitle_1-default UNKNOWN_TYPE | _1_gender | Female | F | _1_personTitle_1-default
ADDRESS_HOME_COUNTRY | _1_country | Country USA & Territories | USA | _1_personTitle_1-default ADDRESS_HOME_COUNTRY | _1_country | Country USA & Territories | USA | _1_country_1-default
ADDRESS_HOME_ZIP | _1_JPNPostal | Postal Code | | _1_personTitle_1-default ADDRESS_HOME_ZIP | _1_JPNPostal | Postal Code | | _1_country_1-default
UNKNOWN_TYPE | _1_JPNPrefecture | Prefecture | | _1_personTitle_1-default UNKNOWN_TYPE | _1_JPNPrefecture | Prefecture | | _1_country_1-default
ADDRESS_HOME_CITY | _1_JPNCity | City | | _1_personTitle_1-default ADDRESS_HOME_CITY | _1_JPNCity | City | | _1_country_1-default
ADDRESS_HOME_LINE1 | _1_address1 | Address | | _1_personTitle_1-default ADDRESS_HOME_LINE1 | _1_address1 | Address | | _1_country_1-default
ADDRESS_HOME_LINE2 | _1_address2 | Address Line 2 (optional) | | _1_personTitle_1-default ADDRESS_HOME_LINE2 | _1_address2 | Address Line 2 (optional) | | _1_country_1-default
ADDRESS_HOME_LINE3 | _1_address3 | Address Line 3 (optional) | | _1_personTitle_1-default ADDRESS_HOME_LINE3 | _1_address3 | Address Line 3 (optional) | | _1_country_1-default
ADDRESS_HOME_ZIP | _1_zipCode | Enter Zip for City and State | | _1_zipCode_1-default ADDRESS_HOME_ZIP | _1_zipCode | Enter Zip for City and State | | _1_zipCode_1-default
ADDRESS_HOME_CITY | _1_city | City | | _1_zipCode_1-default ADDRESS_HOME_CITY | _1_city | City | | _1_zipCode_1-default
ADDRESS_HOME_STATE | _1_state | | | _1_zipCode_1-default ADDRESS_HOME_STATE | _1_state | | | _1_zipCode_1-default
......
components/autofill/content/renderer/form_autofill_util.cc
View file @ 8f7fa53a
...@@ -1190,7 +1190,8 @@ void WebFormControlElementToFormField(const WebFormControlElement& element, ...@@ -1190,7 +1190,8 @@ void WebFormControlElementToFormField(const WebFormControlElement& element,
const WebInputElement* input_element = toWebInputElement(&element); const WebInputElement* input_element = toWebInputElement(&element);
if (IsAutofillableInputElement(input_element) || if (IsAutofillableInputElement(input_element) ||
IsTextAreaElement(element)) { IsTextAreaElement(element) ||
IsSelectElement(element)) {
field->is_autofilled = element.isAutofilled(); field->is_autofilled = element.isAutofilled();
field->is_focusable = element.isFocusable(); field->is_focusable = element.isFocusable();
field->should_autocomplete = element.autoComplete(); field->should_autocomplete = element.autoComplete();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment