Commit 8fab32f6 authored by mukai's avatar mukai Committed by Commit bot

Strips some unnecessary deps in app_list_controller_delegate.cc

- app_list_syncable_service is unnecessary at all
- browser_navigator is not necessary, we've introduced OpenURL

BUG=None
R=xiyuan@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/650473002

Cr-Commit-Position: refs/heads/master@{#299378}
parent f4ebb5cd
...@@ -10,11 +10,8 @@ ...@@ -10,11 +10,8 @@
#include "chrome/browser/extensions/install_tracker_factory.h" #include "chrome/browser/extensions/install_tracker_factory.h"
#include "chrome/browser/extensions/launch_util.h" #include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_list_syncable_service.h"
#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/ui/app_list/extension_uninstaller.h" #include "chrome/browser/ui/app_list/extension_uninstaller.h"
#include "chrome/browser/ui/apps/app_info_dialog.h" #include "chrome/browser/ui/apps/app_info_dialog.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_url_handler.h" #include "chrome/common/extensions/manifest_url_handler.h"
#include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_prefs.h"
...@@ -150,13 +147,12 @@ void AppListControllerDelegate::ShowAppInWebStore( ...@@ -150,13 +147,12 @@ void AppListControllerDelegate::ShowAppInWebStore(
is_search_result ? is_search_result ?
AppListControllerDelegate::LAUNCH_FROM_APP_LIST_SEARCH : AppListControllerDelegate::LAUNCH_FROM_APP_LIST_SEARCH :
AppListControllerDelegate::LAUNCH_FROM_APP_LIST); AppListControllerDelegate::LAUNCH_FROM_APP_LIST);
chrome::NavigateParams params( OpenURL(profile,
profile, net::AppendQueryParameter(url,
net::AppendQueryParameter(url, extension_urls::kWebstoreSourceField,
extension_urls::kWebstoreSourceField, source),
source), ui::PAGE_TRANSITION_LINK,
ui::PAGE_TRANSITION_LINK); CURRENT_TAB);
chrome::Navigate(&params);
} }
bool AppListControllerDelegate::HasOptionsPage( bool AppListControllerDelegate::HasOptionsPage(
...@@ -174,11 +170,10 @@ void AppListControllerDelegate::ShowOptionsPage( ...@@ -174,11 +170,10 @@ void AppListControllerDelegate::ShowOptionsPage(
if (!extension) if (!extension)
return; return;
chrome::NavigateParams params( OpenURL(profile,
profile, extensions::OptionsPageInfo::GetOptionsPage(extension),
extensions::OptionsPageInfo::GetOptionsPage(extension), ui::PAGE_TRANSITION_LINK,
ui::PAGE_TRANSITION_LINK); CURRENT_TAB);
chrome::Navigate(&params);
} }
extensions::LaunchType AppListControllerDelegate::GetExtensionLaunchType( extensions::LaunchType AppListControllerDelegate::GetExtensionLaunchType(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment