Commit 8fb47ccd authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Revert "Enable init_stack_vars for non-official Debug Windows builds"

This reverts commit d140b7a4.

Reason for revert: Broke crashpad_tests reliably
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/12597

Original change's description:
> Enable init_stack_vars for non-official Debug Windows builds
> 
> Debug build is fixed with: crrev.com/c/1973353
> 
> Bug: 977230, 1030261
> Change-Id: Idcb24d092247f6bc7438c74b6405b4b93539507d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970852
> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728840}

TBR=hans@chromium.org,vitalybuka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 977230, 1030261
Change-Id: Iad7d92e12299365b4a45a5237c3bc5e371e33dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993964Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730123}
parent a2c64d86
...@@ -143,10 +143,11 @@ declare_args() { ...@@ -143,10 +143,11 @@ declare_args() {
# rest with 0xAA. This makes behavior of uninitialized memory bugs consistent, # rest with 0xAA. This makes behavior of uninitialized memory bugs consistent,
# recognizeble in debugger, and crashes memory accesses by uninitialized # recognizeble in debugger, and crashes memory accesses by uninitialized
# pointers. # pointers.
# TODO(vitalybuka): # TODO(vitalybuka): investigate why some debug windows bots fail tests.
# 'is_android' breaks content_shell_test_apk on android-kitkat-arm-rel. # 'is_android' breaks content_shell_test_apk on android-kitkat-arm-rel.
# 'use_xcode_clang' may call old clang. # 'use_xcode_clang' may call old clang.
init_stack_vars = !is_android && !use_xcode_clang && !is_official_build init_stack_vars = !is_android && !(is_win && is_debug) && !use_xcode_clang &&
!is_official_build
} }
declare_args() { declare_args() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment