Commit 8fcee60c authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Disable drag-and-drop for StartSurface for now

Bug: 1005931
Change-Id: If6e7f76d463ded6e30468bcaddd3bc99e3f94b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825902Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700034}
parent 7adb8cf4
...@@ -83,9 +83,13 @@ public class TabGridItemTouchHelperCallback extends ItemTouchHelper.SimpleCallba ...@@ -83,9 +83,13 @@ public class TabGridItemTouchHelperCallback extends ItemTouchHelper.SimpleCallba
boolean isTabGroupEnabled = FeatureUtilities.isTabGroupsAndroidEnabled(); boolean isTabGroupEnabled = FeatureUtilities.isTabGroupsAndroidEnabled();
boolean isTabGroupUiImprovementEnabled = boolean isTabGroupUiImprovementEnabled =
FeatureUtilities.isTabGroupsAndroidUiImprovementsEnabled(); FeatureUtilities.isTabGroupsAndroidUiImprovementsEnabled();
boolean isStartSurfaceEnabled = FeatureUtilities.isStartSurfaceEnabled();
// Only enable drag for users with group disabled, or with group and group ui improvement // Only enable drag for users with group disabled, or with group and group ui improvement
// enabled at the same time. // enabled at the same time. Also, disable drag for start surface for now.
boolean isDragEnabled = !isTabGroupEnabled || isTabGroupUiImprovementEnabled; // TODO(crbug.com/1005931): Figure out how drag-to-reorder lives in StartSurface MRU
// ordering scenario.
boolean isDragEnabled =
!isStartSurfaceEnabled && (!isTabGroupEnabled || isTabGroupUiImprovementEnabled);
mDragFlags = isDragEnabled ? ItemTouchHelper.START | ItemTouchHelper.END mDragFlags = isDragEnabled ? ItemTouchHelper.START | ItemTouchHelper.END
| ItemTouchHelper.UP | ItemTouchHelper.DOWN | ItemTouchHelper.UP | ItemTouchHelper.DOWN
: 0; : 0;
......
...@@ -127,7 +127,8 @@ public class TabSwitcherCoordinator implements Destroyable, TabSwitcher, ...@@ -127,7 +127,8 @@ public class TabSwitcherCoordinator implements Destroyable, TabSwitcher,
mTabListCoordinator.getContainerView(), TabListContainerViewBinder::bind); mTabListCoordinator.getContainerView(), TabListContainerViewBinder::bind);
if (FeatureUtilities.isTabGroupsAndroidUiImprovementsEnabled() if (FeatureUtilities.isTabGroupsAndroidUiImprovementsEnabled()
&& mode == TabListCoordinator.TabListMode.GRID) { && mode == TabListCoordinator.TabListMode.GRID
&& !FeatureUtilities.isStartSurfaceEnabled()) {
mTabGridIphItemCoordinator = new TabGridIphItemCoordinator( mTabGridIphItemCoordinator = new TabGridIphItemCoordinator(
context, mTabListCoordinator.getContainerView(), container); context, mTabListCoordinator.getContainerView(), container);
mMediator.setIphProvider(mTabGridIphItemCoordinator.getIphProvider()); mMediator.setIphProvider(mTabGridIphItemCoordinator.getIphProvider());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment