Commit 9012110d authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

🤠 Fix typo when disabling FormControlBrowserTest on Android.

Context:
https://chromium-review.googlesource.com/c/chromium/src/+/2232320/2/content/browser/form_controls_browsertest.cc#141

This patch fixes the typo and uses the more common MAYBE_ pattern.

BUG=1091661

Change-Id: I916faa0c88697ae4887d38ec4591c00a9330ae08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307214Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790395}
parent dfd77274
...@@ -134,14 +134,13 @@ class FormControlsBrowserTest : public ContentBrowserTest { ...@@ -134,14 +134,13 @@ class FormControlsBrowserTest : public ContentBrowserTest {
std::unique_ptr<base::test::ScopedFeatureList> feature_list_; std::unique_ptr<base::test::ScopedFeatureList> feature_list_;
}; };
// Flaky: https://crbug.com/1091661.
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
#define DISABLED_ON_ANDROID(name) DISABLED##name #define MAYBE_Checkbox DISABLED_CheckBox
#else #else
#define DISABLED_ON_ANDROID(name) name #define MAYBE_Checkbox CheckBox
#endif #endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_Checkbox) {
// Flaky: https://crbug.com/1091661
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, DISABLED_ON_ANDROID(Checkbox)) {
RunFormControlsTest( RunFormControlsTest(
"form_controls_browsertest_checkbox", "form_controls_browsertest_checkbox",
"<input type=checkbox>" "<input type=checkbox>"
...@@ -156,8 +155,13 @@ IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, DISABLED_ON_ANDROID(Checkbox)) { ...@@ -156,8 +155,13 @@ IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, DISABLED_ON_ANDROID(Checkbox)) {
/* screenshot_height */ 40); /* screenshot_height */ 40);
} }
// Flaky: https://crbug.com/1091661 // Flaky: https://crbug.com/1091661.
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, DISABLED_ON_ANDROID(Radio)) { #if defined(OS_ANDROID)
#define MAYBE_Radio DISABLED_Radio
#else
#define MAYBE_Radio Radio
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_Radio) {
RunFormControlsTest( RunFormControlsTest(
"form_controls_browsertest_radio", "form_controls_browsertest_radio",
"<input type=radio>" "<input type=radio>"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment