Commit 90147459 authored by davidben's avatar davidben Committed by Commit bot

Remove NavigationRequestInfo::is_showing.

Trying to initialize it causes content_shell --enable-browser-side-navigation
to crash on startup.

It corresponds to ResourceRequestInfo::GetVisibilityState, but that's only used
for categorizing requests made from prerender which needs a different bit
(WebPageVisiblityStatePrerender vs. others), so we'll need to revisit it
anyway.

BUG=376014

Review URL: https://codereview.chromium.org/534393002

Cr-Commit-Position: refs/heads/master@{#293211}
parent b0b78ba7
...@@ -12,8 +12,7 @@ NavigationRequestInfo::NavigationRequestInfo( ...@@ -12,8 +12,7 @@ NavigationRequestInfo::NavigationRequestInfo(
const FrameHostMsg_BeginNavigation_Params& params) const FrameHostMsg_BeginNavigation_Params& params)
: navigation_params(params), : navigation_params(params),
is_main_frame(true), is_main_frame(true),
parent_is_main_frame(false), parent_is_main_frame(false) {
is_showing(true) {
} }
} // namespace content } // namespace content
...@@ -32,9 +32,6 @@ struct NavigationRequestInfo { ...@@ -32,9 +32,6 @@ struct NavigationRequestInfo {
GURL first_party_for_cookies; GURL first_party_for_cookies;
bool is_main_frame; bool is_main_frame;
bool parent_is_main_frame; bool parent_is_main_frame;
// True if the frame is visible.
bool is_showing;
}; };
} // namespace content } // namespace content
......
...@@ -577,7 +577,6 @@ void RenderFrameHostManager::OnBeginNavigation( ...@@ -577,7 +577,6 @@ void RenderFrameHostManager::OnBeginNavigation(
info.is_main_frame = frame_tree_node_->IsMainFrame(); info.is_main_frame = frame_tree_node_->IsMainFrame();
info.parent_is_main_frame = !frame_tree_node_->parent() ? info.parent_is_main_frame = !frame_tree_node_->parent() ?
false : frame_tree_node_->parent()->IsMainFrame(); false : frame_tree_node_->parent()->IsMainFrame();
info.is_showing = GetRenderWidgetHostView()->IsShowing();
// TODO(clamy): Check if the current RFH should be initialized (in case it has // TODO(clamy): Check if the current RFH should be initialized (in case it has
// crashed) not to display a sad tab while navigating. // crashed) not to display a sad tab while navigating.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment