Commit 9015c1ff authored by Sam McNally's avatar Sam McNally Committed by Commit Bot

Add missing deps on //chrome/common:service_process_mojom.

//chrome/browser correctly lists //chrome/common:service_process_mojom
in its public_deps. However, //chrome/browser/extensions and
//chrome/browser/ui are listed in allow_circular_includes_from, allowing
them to include headers from //chrome/browser without a dependency. Add
explicit dependencies from //chrome/browser/extensions and
//chrome/browser/ui to //chrome/common:service_process_mojom.

Bug: 805916
Change-Id: I83c2c7588e8056d413b9cccc8f5eceeb203986d7
Reviewed-on: https://chromium-review.googlesource.com/890686
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532517}
parent 694bf0eb
......@@ -1111,6 +1111,7 @@ static_library("extensions") {
"api/cloud_print_private/cloud_print_private_api.cc",
"api/cloud_print_private/cloud_print_private_api.h",
]
deps += [ "//chrome/common:service_process_mojom" ]
}
if (enable_service_discovery) {
......
......@@ -3674,6 +3674,9 @@ split_static_library("ui") {
"webui/local_discovery/local_discovery_ui_handler.cc",
"webui/local_discovery/local_discovery_ui_handler.h",
]
if (enable_print_preview && !is_chromeos) {
deps += [ "//chrome/common:service_process_mojom" ]
}
}
if (enable_webrtc) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment