Commit 904e9c78 authored by Frank Liberato's avatar Frank Liberato Committed by Commit Bot

Revert "[Build Sheriff] Disable various tests pending fix."

This reverts commit 6e1bb98a.

Reason for revert: https://chromium-review.googlesource.com/1238859 reverted the original CL, tests pass again.

Original change's description:
> [Build Sheriff] Disable various tests pending fix.
> 
> NOTRY=true
> TBR=nohle@chromium.org, dtrainor@chromium.org
> 
> Bug: 887953
> Change-Id: I3a3f3ea828c86873fdea72d75c50a83a83271408
> Reviewed-on: https://chromium-review.googlesource.com/1238377
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593189}

TBR=liberato@chromium.org

Change-Id: Idf5e5d75ed6087c52d6b70e0e51126ceec000a27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887953
Reviewed-on: https://chromium-review.googlesource.com/1239257Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593262}
parent 41bdcc18
...@@ -298,7 +298,7 @@ class DownloadNotificationTest : public DownloadNotificationTestBase { ...@@ -298,7 +298,7 @@ class DownloadNotificationTest : public DownloadNotificationTestBase {
DISALLOW_COPY_AND_ASSIGN(DownloadNotificationTest); DISALLOW_COPY_AND_ASSIGN(DownloadNotificationTest);
}; };
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadFile) { IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadFile) {
CreateDownload(); CreateDownload();
EXPECT_EQ(l10n_util::GetStringFUTF16( EXPECT_EQ(l10n_util::GetStringFUTF16(
...@@ -441,7 +441,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadImageFile) { ...@@ -441,7 +441,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadImageFile) {
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_CloseNotificationAfterDownload) { CloseNotificationAfterDownload) {
CreateDownload(); CreateDownload();
CompleteTheDownload(); CompleteTheDownload();
...@@ -452,7 +452,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -452,7 +452,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_CloseNotificationWhileDownloading) { CloseNotificationWhileDownloading) {
CreateDownload(); CreateDownload();
CloseNotification(); CloseNotification();
...@@ -464,7 +464,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -464,7 +464,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
EXPECT_TRUE(notification()); EXPECT_TRUE(notification());
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_InterruptDownload) { IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, InterruptDownload) {
CreateDownload(); CreateDownload();
InterruptTheDownload(); InterruptTheDownload();
...@@ -487,7 +487,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_InterruptDownload) { ...@@ -487,7 +487,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_InterruptDownload) {
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_InterruptDownloadAfterClosingNotification) { InterruptDownloadAfterClosingNotification) {
CreateDownload(); CreateDownload();
CloseNotification(); CloseNotification();
...@@ -511,7 +511,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -511,7 +511,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
ASSERT_TRUE(notification()); ASSERT_TRUE(notification());
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadRemoved) { IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadRemoved) {
CreateDownload(); CreateDownload();
EXPECT_TRUE(notification()); EXPECT_TRUE(notification());
...@@ -524,8 +524,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadRemoved) { ...@@ -524,8 +524,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_DownloadRemoved) {
EXPECT_EQ(0u, downloads.size()); EXPECT_EQ(0u, downloads.size());
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadMultipleFiles) {
DISABLED_DownloadMultipleFiles) {
GURL url1(net::URLRequestSlowDownloadJob::kUnknownSizeUrl); GURL url1(net::URLRequestSlowDownloadJob::kUnknownSizeUrl);
GURL url2(net::URLRequestSlowDownloadJob::kKnownSizeUrl); GURL url2(net::URLRequestSlowDownloadJob::kKnownSizeUrl);
...@@ -617,7 +616,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -617,7 +616,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_DownloadMultipleFilesOneByOne) { DownloadMultipleFilesOneByOne) {
CreateDownload(); CreateDownload();
download::DownloadItem* first_download_item = download_item(); download::DownloadItem* first_download_item = download_item();
std::string first_notification_id = notification_id(); std::string first_notification_id = notification_id();
...@@ -659,7 +658,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -659,7 +658,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
EXPECT_EQ(2u, GetDownloadNotifications().size()); EXPECT_EQ(2u, GetDownloadNotifications().size());
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_CancelDownload) { IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, CancelDownload) {
CreateDownload(); CreateDownload();
// Cancels the notification by clicking the "cancel" button. // Cancels the notification by clicking the "cancel" button.
...@@ -676,7 +675,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_CancelDownload) { ...@@ -676,7 +675,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DISABLED_CancelDownload) {
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_DownloadCancelledByUserExternally) { DownloadCancelledByUserExternally) {
CreateDownload(); CreateDownload();
// Cancels the notification through the DownloadItem. // Cancels the notification through the DownloadItem.
...@@ -691,8 +690,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -691,8 +690,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
EXPECT_EQ(download::DownloadItem::CANCELLED, downloads[0]->GetState()); EXPECT_EQ(download::DownloadItem::CANCELLED, downloads[0]->GetState());
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IncognitoDownloadFile) {
DISABLED_IncognitoDownloadFile) {
PrepareIncognitoBrowser(); PrepareIncognitoBrowser();
// Starts an incognito download. // Starts an incognito download.
...@@ -737,7 +735,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, ...@@ -737,7 +735,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
} }
IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
DISABLED_SimultaneousIncognitoAndNormalDownloads) { SimultaneousIncognitoAndNormalDownloads) {
PrepareIncognitoBrowser(); PrepareIncognitoBrowser();
GURL url_incognito(net::URLRequestSlowDownloadJob::kUnknownSizeUrl); GURL url_incognito(net::URLRequestSlowDownloadJob::kUnknownSizeUrl);
...@@ -902,7 +900,7 @@ IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest, ...@@ -902,7 +900,7 @@ IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest,
} }
IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest, IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest,
DISABLED_DownloadMultipleFiles) { DownloadMultipleFiles) {
AddAllUsers(); AddAllUsers();
GURL url(net::URLRequestSlowDownloadJob::kUnknownSizeUrl); GURL url(net::URLRequestSlowDownloadJob::kUnknownSizeUrl);
......
...@@ -580,7 +580,7 @@ IN_PROC_BROWSER_TEST_F(KeyboardLockInteractiveBrowserTest, ...@@ -580,7 +580,7 @@ IN_PROC_BROWSER_TEST_F(KeyboardLockInteractiveBrowserTest,
} }
IN_PROC_BROWSER_TEST_F(KeyboardLockInteractiveBrowserTest, IN_PROC_BROWSER_TEST_F(KeyboardLockInteractiveBrowserTest,
DISABLED_DownloadNavigationDoesNotUnlock) { DownloadNavigationDoesNotUnlock) {
ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage()); ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage());
ASSERT_TRUE(DisablePreventDefaultOnTestPage()); ASSERT_TRUE(DisablePreventDefaultOnTestPage());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment