Commit 90631306 authored by David Benjamin's avatar David Benjamin Committed by Commit Bot

Only call ToString in fuzzer if IsSetConfig.

ToString (which is a test-only method so it doesn't really matter) is
only call if IsSetConfig, not !IsParseError

Bug: 954766
Change-Id: I1e956cb374d5bf9899e16942f6c13868e29e6100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577563
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: default avatarMatt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652906}
parent 15b1d752
...@@ -279,6 +279,7 @@ DomainReliabilityHeader::ReleaseConfig() { ...@@ -279,6 +279,7 @@ DomainReliabilityHeader::ReleaseConfig() {
} }
std::string DomainReliabilityHeader::ToString() const { std::string DomainReliabilityHeader::ToString() const {
DCHECK_EQ(PARSE_SET_CONFIG, status_);
std::string string; std::string string;
int64_t max_age_s = max_age_.InSeconds(); int64_t max_age_s = max_age_.InSeconds();
......
...@@ -44,6 +44,8 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityHeader { ...@@ -44,6 +44,8 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityHeader {
std::unique_ptr<DomainReliabilityConfig> ReleaseConfig(); std::unique_ptr<DomainReliabilityConfig> ReleaseConfig();
// Converts the config to a string. This may only be called if IsSetConfig()
// returns true.
std::string ToString() const; std::string ToString() const;
private: private:
......
...@@ -28,7 +28,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { ...@@ -28,7 +28,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
base::StringPiece input(reinterpret_cast<const char*>(data), size); base::StringPiece input(reinterpret_cast<const char*>(data), size);
std::unique_ptr<DomainReliabilityHeader> header = std::unique_ptr<DomainReliabilityHeader> header =
DomainReliabilityHeader::Parse(input); DomainReliabilityHeader::Parse(input);
if (!header->IsParseError()) { if (header->IsSetConfig()) {
header->ToString(); header->ToString();
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment