Fix TabUsageRecorder:testOpenLinkInNewTab

Use standard way to select tab.

Bug: None
Change-Id: I531a3e450d93c860b62f8896379e8097d7b1f622
Reviewed-on: https://chromium-review.googlesource.com/684438Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504347}

ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

@@ -132,16 +132,6 @@ void CloseTabAtIndexAndSync(NSUInteger i) {
       testing::WaitUntilConditionOrTimeout(kWaitElementTimeout, condition),
       @"Waiting for tab to close");
 }
-
-// Select the tab with title |title| using UI (tab strip on iPad, stack view on
-// iPhone).
-void SelectTabUsingUI(NSString* title) {
-  if (IsCompact()) {
-    WaitAndTap(chrome_test_util::ShowTabsButton(), @"Tab switcher");
-  }
-  WaitAndTap(grey_text(title),
-             [NSString stringWithFormat:@"tab with title %@", title]);
-}
 }  // namespace
 
 // Test for the TabUsageRecorder class.
@@ -700,7 +690,7 @@ void SelectTabUsingUI(NSString* title) {
       performAction:grey_tap()];
   [ChromeEarlGrey waitForMainTabCount:(numberOfTabs + 1)];
 
-  SelectTabUsingUI(base::SysUTF8ToNSString(destinationURL.GetContent()));
+  chrome_test_util::SelectTabAtIndexInCurrentMode(numberOfTabs);
 
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   [ChromeEarlGrey waitForWebViewContainingText:"Whee"];