Commit 907a5169 authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Disable SimpleURLLoader exceed limits tests.

I believe there's a bug in URLLoader that's causing them to occasionally
crash, when the data pipe is closed before reading the entire response
body.

TBR=jam@chromium.org
NOTRY=true

Bug: 755309
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id3f98fdea01b56b1c0c3b0edf927701579afa38d
Reviewed-on: https://chromium-review.googlesource.com/1012443Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550688}
parent 77d75ce9
...@@ -953,7 +953,8 @@ TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeBelowLimit) { ...@@ -953,7 +953,8 @@ TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeBelowLimit) {
EXPECT_EQ(std::string(kResponseSize, 'a'), *test_helper->response_body()); EXPECT_EQ(std::string(kResponseSize, 'a'), *test_helper->response_body());
} }
TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeAboveLimit) { // Disabled: See https://crbug.com/832600
TEST_P(SimpleURLLoaderTest, DISABLED_ResponseBodyWithSizeAboveLimit) {
// Download to stream doesn't support response sizes. // Download to stream doesn't support response sizes.
if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM) if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM)
return; return;
...@@ -971,7 +972,9 @@ TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeAboveLimit) { ...@@ -971,7 +972,9 @@ TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeAboveLimit) {
} }
// Same as above, but with setting allow_partial_results to true. // Same as above, but with setting allow_partial_results to true.
TEST_P(SimpleURLLoaderTest, ResponseBodyWithSizeAboveLimitPartialResponse) { // Disabled: See https://crbug.com/832600
TEST_P(SimpleURLLoaderTest,
DISABLED_ResponseBodyWithSizeAboveLimitPartialResponse) {
// Download to stream doesn't support response sizes. // Download to stream doesn't support response sizes.
if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM) if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM)
return; return;
...@@ -1031,7 +1034,8 @@ TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeBelowLimit) { ...@@ -1031,7 +1034,8 @@ TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeBelowLimit) {
EXPECT_EQ(std::string(kResponseSize, 'a'), *test_helper->response_body()); EXPECT_EQ(std::string(kResponseSize, 'a'), *test_helper->response_body());
} }
TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeAboveLimit) { // Disabled: See https://crbug.com/832600
TEST_P(SimpleURLLoaderTest, DISABLED_BigResponseBodyWithSizeAboveLimit) {
// Download to stream doesn't support response sizes. // Download to stream doesn't support response sizes.
if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM) if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM)
return; return;
...@@ -1048,7 +1052,9 @@ TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeAboveLimit) { ...@@ -1048,7 +1052,9 @@ TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeAboveLimit) {
EXPECT_FALSE(test_helper->response_body()); EXPECT_FALSE(test_helper->response_body());
} }
TEST_P(SimpleURLLoaderTest, BigResponseBodyWithSizeAboveLimitPartialResponse) { // Disabled: See https://crbug.com/832600
TEST_P(SimpleURLLoaderTest,
DISABLED_BigResponseBodyWithSizeAboveLimitPartialResponse) {
// Download to stream doesn't support response sizes. // Download to stream doesn't support response sizes.
if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM) if (GetParam() == SimpleLoaderTestHelper::DownloadType::AS_STREAM)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment