Commit 90aece5c authored by Oksana Zhuravlova's avatar Oksana Zhuravlova Committed by Commit Bot

[mojo] Do not request BadgeService interface on Android

Since the browser does not bind the BadgeService on Android,
this change adds corresponding conditions to the renderer side.

Bug: 1062106
Change-Id: I905676ec94d5aaa697ef279167a15efd5b8ddd5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106921Reviewed-by: default avatarChris Mumford <cmumford@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751001}
parent 7b6e4359
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "third_party/blink/renderer/modules/badging/navigator_badge.h" #include "third_party/blink/renderer/modules/badging/navigator_badge.h"
#include "build/build_config.h"
#include "third_party/blink/public/common/browser_interface_broker_proxy.h" #include "third_party/blink/public/common/browser_interface_broker_proxy.h"
#include "third_party/blink/renderer/bindings/core/v8/script_promise.h" #include "third_party/blink/renderer/bindings/core/v8/script_promise.h"
#include "third_party/blink/renderer/core/execution_context/execution_context.h" #include "third_party/blink/renderer/core/execution_context/execution_context.h"
...@@ -82,13 +83,17 @@ ScriptPromise NavigatorBadge::SetAppBadgeHelper( ...@@ -82,13 +83,17 @@ ScriptPromise NavigatorBadge::SetAppBadgeHelper(
if (badge_value->is_number() && badge_value->get_number() == 0) if (badge_value->is_number() && badge_value->get_number() == 0)
return ClearAppBadgeHelper(script_state); return ClearAppBadgeHelper(script_state);
#if !defined(OS_ANDROID)
From(script_state).badge_service()->SetBadge(std::move(badge_value)); From(script_state).badge_service()->SetBadge(std::move(badge_value));
#endif
return ScriptPromise::CastUndefined(script_state); return ScriptPromise::CastUndefined(script_state);
} }
// static // static
ScriptPromise NavigatorBadge::ClearAppBadgeHelper(ScriptState* script_state) { ScriptPromise NavigatorBadge::ClearAppBadgeHelper(ScriptState* script_state) {
#if !defined(OS_ANDROID)
From(script_state).badge_service()->ClearBadge(); From(script_state).badge_service()->ClearBadge();
#endif
return ScriptPromise::CastUndefined(script_state); return ScriptPromise::CastUndefined(script_state);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment