Commit 90aef9d9 authored by rsleevi's avatar rsleevi Committed by Commit bot

Move the known CT logs to the read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351

Review-Url: https://codereview.chromium.org/2613723005
Cr-Commit-Position: refs/heads/master@{#441804}
parent 5807dc6e
...@@ -4,21 +4,21 @@ ...@@ -4,21 +4,21 @@
struct CTLogInfo { struct CTLogInfo {
// The DER-encoded SubjectPublicKeyInfo for the log. // The DER-encoded SubjectPublicKeyInfo for the log.
const char* const log_key; const char* log_key;
// The length, in bytes, of |log_key|. // The length, in bytes, of |log_key|.
const size_t log_key_length; size_t log_key_length;
// The user-friendly log name. // The user-friendly log name.
// Note: This will not be translated. // Note: This will not be translated.
const char* const log_name; const char* log_name;
// The HTTPS API endpoint for the log. // The HTTPS API endpoint for the log.
// Note: Trailing slashes should be included. // Note: Trailing slashes should be included.
const char* const log_url; const char* log_url;
// The DNS API endpoint for the log. // The DNS API endpoint for the log.
// This is used as the parent domain for all queries about the log. // This is used as the parent domain for all queries about the log.
// If empty, CT DNS queries are not supported for the log. This will prevent // If empty, CT DNS queries are not supported for the log. This will prevent
// retrieval of inclusion proofs over DNS for SCTs from the log. // retrieval of inclusion proofs over DNS for SCTs from the log.
// https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md. // https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md.
const char* const log_dns_domain; const char* log_dns_domain;
}; };
// The set of all presently-qualifying CT logs. // The set of all presently-qualifying CT logs.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment