Commit 90f4ba6e authored by Irina Yatsenko's avatar Irina Yatsenko Committed by Commit Bot

Add default case in AddCrashKey

This allows to avoid build breaks when new ids are added on v8's side.

Bug: chromium:1010312
Change-Id: Ia375cc842137e4b58f801e0fcc63d2222b0cf482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841933Reviewed-by: default avatarStefan Zager <szager@chromium.org>
Commit-Queue: Irina Yatsenko <irinayat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703494}
parent 9be48344
......@@ -304,6 +304,10 @@ void AddCrashKey(v8::CrashKeyId id, const std::string& value) {
bd::CrashKeySize::Size32);
bd::SetCrashKeyString(code_space_firstpage_address, value);
break;
default:
// Doing nothing for new keys is a valid option. Having this case allows
// to introduce new CrashKeyId's without triggering a build break.
break;
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment