Commit 90f6d679 authored by David Black's avatar David Black Committed by Commit Bot

Interacting w/ virtual keyboard shouldn't dismiss Assistant.

Previously only workspace occluded bounds were checked. This handled
the default virtual keyboard case but not the floating virtual
keyboard case. To handle both cases, we need to check visual bounds.

Bug: b:140987575
Change-Id: I6d2012c28f1202181d5db27ab5dbea6b2f51952b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836665
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702544}
parent 00c514ed
...@@ -694,8 +694,10 @@ void AssistantUiController::OnEvent(const ui::Event& event) { ...@@ -694,8 +694,10 @@ void AssistantUiController::OnEvent(const ui::Event& event) {
const gfx::Rect screen_bounds = const gfx::Rect screen_bounds =
container_view_->GetWidget()->GetWindowBoundsInScreen(); container_view_->GetWidget()->GetWindowBoundsInScreen();
const gfx::Rect keyboard_bounds = keyboard::KeyboardUIController::Get() const gfx::Rect keyboard_bounds =
->GetWorkspaceOccludedBoundsInScreen(); keyboard::KeyboardUIController::Get()->IsKeyboardVisible()
? keyboard::KeyboardUIController::Get()->GetVisualBoundsInScreen()
: gfx::Rect();
// Pressed events outside our widget bounds should result in hiding of the // Pressed events outside our widget bounds should result in hiding of the
// Assistant UI. The exception to this rule is if the user is interacting // Assistant UI. The exception to this rule is if the user is interacting
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment