Commit 90ff4513 authored by estade@chromium.org's avatar estade@chromium.org

[rAc - i18n] don't call callbacks on Storage destruction

The leaks this would have caused before should now be fixed.

BUG=none

Review URL: https://codereview.chromium.org/132723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244097 0039d316-1c4b-4281-b951-d872f2087c98
parent e766ad32
...@@ -13,14 +13,7 @@ ChromeStorageImpl::ChromeStorageImpl(WriteablePrefStore* store) ...@@ -13,14 +13,7 @@ ChromeStorageImpl::ChromeStorageImpl(WriteablePrefStore* store)
scoped_observer_.Add(backing_store_); scoped_observer_.Add(backing_store_);
} }
ChromeStorageImpl::~ChromeStorageImpl() { ChromeStorageImpl::~ChromeStorageImpl() {}
// TODO(estade): this shouldn't be necessary.
for (std::vector<Request*>::iterator iter =
outstanding_requests_.begin();
iter != outstanding_requests_.end(); ++iter) {
(*(*iter)->callback)(false, (*iter)->key, std::string());
}
}
void ChromeStorageImpl::Put(const std::string& key, const std::string& data) { void ChromeStorageImpl::Put(const std::string& key, const std::string& data) {
backing_store_->SetValue(key, new base::StringValue(data)); backing_store_->SetValue(key, new base::StringValue(data));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment