Commit 9115f726 authored by Jimmy Gong's avatar Jimmy Gong Committed by Chromium LUCI CQ

Phone Hub: Update label for Phone Hub UI settings button

Provide more context on where the setting buttons is routed to.

Screenshot:
https://storage.cloud.google.com/chromium-translation-screenshots/ad7a89eaab68906ed5e04fc18cf4f6cacd1ef94c

Fixed: 1152781
Change-Id: I0fef47d663c41f20ba3842820d661967bbc08066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570328
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834004}
parent 4c3aa471
...@@ -1201,6 +1201,9 @@ This file contains the strings for ash. ...@@ -1201,6 +1201,9 @@ This file contains the strings for ash.
<message name="IDS_ASH_PHONE_HUB_CONTINUE_BROWSING_TAB_LABEL" desc="Label inside a Phone Hub continue browsing card that describes the index of the card, title of the webpage, and webpage url."> <message name="IDS_ASH_PHONE_HUB_CONTINUE_BROWSING_TAB_LABEL" desc="Label inside a Phone Hub continue browsing card that describes the index of the card, title of the webpage, and webpage url.">
Browser tab <ph name="INDEX">$1<ex>1</ex></ph> of <ph name="TOTAL_COUNT">$2<ex>2</ex></ph>. <ph name="SITE_TITLE">$3<ex>Google</ex></ph>, <ph name="SITE_URL">$4<ex>https://google.com</ex></ph> Browser tab <ph name="INDEX">$1<ex>1</ex></ph> of <ph name="TOTAL_COUNT">$2<ex>2</ex></ph>. <ph name="SITE_TITLE">$3<ex>Google</ex></ph>, <ph name="SITE_URL">$4<ex>https://google.com</ex></ph>
</message> </message>
<message name="IDS_ASH_PHONE_HUB_CONNECTED_DEVICE_SETTINGS_LABEL" desc="Label for the settings button in the Phone Hub UI that lets users know that the button routes to the Chrome OS Settings app page for connected devices (e.g. to disable Phone Hub features, enable/disable Smartlock, etc)">
Connected devices settings
</message>
<message name="IDS_ASH_STYLUS_TOOLS_CAPTURE_REGION_ACTION" desc="Title of the capture region action in the stylus tools (a pop-up panel next to the status tray). This causes a partial screenshot to be taken (the user selects an area of the screen to take a screenshot of)."> <message name="IDS_ASH_STYLUS_TOOLS_CAPTURE_REGION_ACTION" desc="Title of the capture region action in the stylus tools (a pop-up panel next to the status tray). This causes a partial screenshot to be taken (the user selects an area of the screen to take a screenshot of).">
Capture region Capture region
......
ad7a89eaab68906ed5e04fc18cf4f6cacd1ef94c
\ No newline at end of file
...@@ -162,7 +162,8 @@ PhoneStatusView::PhoneStatusView(chromeos::phonehub::PhoneModel* phone_model, ...@@ -162,7 +162,8 @@ PhoneStatusView::PhoneStatusView(chromeos::phonehub::PhoneModel* phone_model,
settings_button_ = new TopShortcutButton( settings_button_ = new TopShortcutButton(
base::BindRepeating(&Delegate::OpenConnectedDevicesSettings, base::BindRepeating(&Delegate::OpenConnectedDevicesSettings,
base::Unretained(delegate)), base::Unretained(delegate)),
kSystemMenuSettingsIcon, IDS_ASH_STATUS_TRAY_SETTINGS); kSystemMenuSettingsIcon,
IDS_ASH_PHONE_HUB_CONNECTED_DEVICE_SETTINGS_LABEL);
AddView(TriView::Container::END, settings_button_); AddView(TriView::Container::END, settings_button_);
separator_->SetVisible(delegate->CanOpenConnectedDeviceSettings()); separator_->SetVisible(delegate->CanOpenConnectedDeviceSettings());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment