Commit 916dfb69 authored by creis@chromium.org's avatar creis@chromium.org

Prepare for a change in contract to WebViewClient::createView.

No behavior change.

BUG=69267
TEST=none


Review URL: http://codereview.chromium.org/9583026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124921 0039d316-1c4b-4281-b951-d872f2087c98
parent 98a47ec7
...@@ -1427,6 +1427,17 @@ bool RenderViewImpl::SendAndRunNestedMessageLoop(IPC::SyncMessage* message) { ...@@ -1427,6 +1427,17 @@ bool RenderViewImpl::SendAndRunNestedMessageLoop(IPC::SyncMessage* message) {
// WebKit::WebViewClient ------------------------------------------------------ // WebKit::WebViewClient ------------------------------------------------------
// TODO(creis): New contract for createView temporarily redirects to the old
// contract. Remove the old one as part of http://crbug.com/69267.
WebView* RenderViewImpl::createView(
WebFrame* creator,
const WebURLRequest& request,
const WebWindowFeatures& features,
const WebString& frame_name,
WebNavigationPolicy policy) {
return createView(creator, request, features, frame_name);
}
WebView* RenderViewImpl::createView( WebView* RenderViewImpl::createView(
WebFrame* creator, WebFrame* creator,
const WebURLRequest& request, const WebURLRequest& request,
......
...@@ -334,6 +334,13 @@ class RenderViewImpl : public RenderWidget, ...@@ -334,6 +334,13 @@ class RenderViewImpl : public RenderWidget,
// WebKit::WebViewClient implementation -------------------------------------- // WebKit::WebViewClient implementation --------------------------------------
virtual WebKit::WebView* createView(
WebKit::WebFrame* creator,
const WebKit::WebURLRequest& request,
const WebKit::WebWindowFeatures& features,
const WebKit::WebString& frame_name,
WebKit::WebNavigationPolicy policy);
// TODO(creis): Remove as part of http://crbug.com/69267.
virtual WebKit::WebView* createView( virtual WebKit::WebView* createView(
WebKit::WebFrame* creator, WebKit::WebFrame* creator,
const WebKit::WebURLRequest& request, const WebKit::WebURLRequest& request,
......
...@@ -318,6 +318,15 @@ void TestWebViewDelegate::SetAuthorAndUserStylesEnabled(bool is_enabled) { ...@@ -318,6 +318,15 @@ void TestWebViewDelegate::SetAuthorAndUserStylesEnabled(bool is_enabled) {
} }
// WebViewClient ------------------------------------------------------------- // WebViewClient -------------------------------------------------------------
// TODO(creis): Remove as part of http://crbug.com/69267.
WebView* TestWebViewDelegate::createView(
WebFrame* creator,
const WebURLRequest& request,
const WebWindowFeatures& window_features,
const WebString& frame_name,
WebNavigationPolicy policy) {
return createView(creator, request, window_features, frame_name);
}
WebView* TestWebViewDelegate::createView( WebView* TestWebViewDelegate::createView(
WebFrame* creator, WebFrame* creator,
const WebURLRequest& request, const WebURLRequest& request,
......
...@@ -78,6 +78,13 @@ class TestWebViewDelegate : public WebKit::WebViewClient, ...@@ -78,6 +78,13 @@ class TestWebViewDelegate : public WebKit::WebViewClient,
typedef std::vector<CapturedContextMenuEvent> CapturedContextMenuEvents; typedef std::vector<CapturedContextMenuEvent> CapturedContextMenuEvents;
// WebKit::WebViewClient // WebKit::WebViewClient
virtual WebKit::WebView* createView(
WebKit::WebFrame* creator,
const WebKit::WebURLRequest& request,
const WebKit::WebWindowFeatures& features,
const WebKit::WebString& frame_name,
WebKit::WebNavigationPolicy policy);
// TODO(creis): Remove as part of http://crbug.com/69267.
virtual WebKit::WebView* createView( virtual WebKit::WebView* createView(
WebKit::WebFrame* creator, WebKit::WebFrame* creator,
const WebKit::WebURLRequest& request, const WebKit::WebURLRequest& request,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment