Revert of DevTools: excessive dumping for jump-to-previous-position.html test...

Revert of DevTools: excessive dumping for jump-to-previous-position.html test (https://codereview.chromium.org/285373011/)

Reason for revert:
Looks like test is not accidentally failing any more during last week. Reverting this debugging patch

Original issue's description:
> DevTools: excessive dumping for jump-to-previous-position.html test
> 
> This patch adds excessive dumping for jump-to-previous-position.html test.
> The changes are expected to be reverted as the reason of failures will
> be detected.
> 
> BUG=361588
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174171

TBR=vsevik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361588

Review URL: https://codereview.chromium.org/303383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent dea871eb
...@@ -58,17 +58,6 @@ Running: testCloseCrossFile ...@@ -58,17 +58,6 @@ Running: testCloseCrossFile
<Rolled over> line: 9 column: 4 [example-fileset-for-test.js] <Rolled over> line: 9 column: 4 [example-fileset-for-test.js]
Running: testHistoryDepth Running: testHistoryDepth
=== SimpleHistoryManager state before filling history stack ===
entries count: 8
>entry[7] = {line: 9, column: 4}
entry[6] = null
entry[5] = {line: 9, column: 0}
entry[4] = null
entry[3] = null
entry[2] = null
entry[1] = {line: 7, column: 26}
entry[0] = {line: 2, column: 0}
=== ===
<Mouse click (10, 7)> line: 10 column: 7 [example-fileset-for-test.js] <Mouse click (10, 7)> line: 10 column: 7 [example-fileset-for-test.js]
<Mouse click (11, 7)> line: 11 column: 7 [example-fileset-for-test.js] <Mouse click (11, 7)> line: 11 column: 7 [example-fileset-for-test.js]
<Mouse click (12, 7)> line: 12 column: 7 [example-fileset-for-test.js] <Mouse click (12, 7)> line: 12 column: 7 [example-fileset-for-test.js]
...@@ -89,53 +78,6 @@ entries count: 8 ...@@ -89,53 +78,6 @@ entries count: 8
<Mouse click (27, 7)> line: 27 column: 7 [example-fileset-for-test.js] <Mouse click (27, 7)> line: 27 column: 7 [example-fileset-for-test.js]
<Mouse click (28, 7)> line: 28 column: 7 [example-fileset-for-test.js] <Mouse click (28, 7)> line: 28 column: 7 [example-fileset-for-test.js]
<Mouse click (29, 7)> line: 29 column: 7 [example-fileset-for-test.js] <Mouse click (29, 7)> line: 29 column: 7 [example-fileset-for-test.js]
=== SimpleHistoryManager state after filling history stack ===
entries count: 20
>entry[19] = {line: 29, column: 7}
entry[18] = {line: 28, column: 7}
entry[17] = {line: 27, column: 7}
entry[16] = {line: 26, column: 7}
entry[15] = {line: 25, column: 7}
entry[14] = {line: 24, column: 7}
entry[13] = {line: 23, column: 7}
entry[12] = {line: 22, column: 7}
entry[11] = {line: 21, column: 7}
entry[10] = {line: 20, column: 7}
entry[9] = {line: 19, column: 7}
entry[8] = {line: 18, column: 7}
entry[7] = {line: 17, column: 7}
entry[6] = {line: 16, column: 7}
entry[5] = {line: 15, column: 7}
entry[4] = {line: 14, column: 7}
entry[3] = {line: 13, column: 7}
entry[2] = {line: 12, column: 7}
entry[1] = {line: 11, column: 7}
entry[0] = {line: 10, column: 7}
=== ===
First rollback result: true
=== SimpleHistoryManager state after first rollback ===
entries count: 20
entry[19] = {line: 29, column: 7}
>entry[18] = {line: 28, column: 7}
entry[17] = {line: 27, column: 7}
entry[16] = {line: 26, column: 7}
entry[15] = {line: 25, column: 7}
entry[14] = {line: 24, column: 7}
entry[13] = {line: 23, column: 7}
entry[12] = {line: 22, column: 7}
entry[11] = {line: 21, column: 7}
entry[10] = {line: 20, column: 7}
entry[9] = {line: 19, column: 7}
entry[8] = {line: 18, column: 7}
entry[7] = {line: 17, column: 7}
entry[6] = {line: 16, column: 7}
entry[5] = {line: 15, column: 7}
entry[4] = {line: 14, column: 7}
entry[3] = {line: 13, column: 7}
entry[2] = {line: 12, column: 7}
entry[1] = {line: 11, column: 7}
entry[0] = {line: 10, column: 7}
=== ===
<Rolled back> line: 28 column: 7 [example-fileset-for-test.js] <Rolled back> line: 28 column: 7 [example-fileset-for-test.js]
<Rolled back> line: 27 column: 7 [example-fileset-for-test.js] <Rolled back> line: 27 column: 7 [example-fileset-for-test.js]
<Rolled back> line: 26 column: 7 [example-fileset-for-test.js] <Rolled back> line: 26 column: 7 [example-fileset-for-test.js]
......
...@@ -177,20 +177,6 @@ function test() ...@@ -177,20 +177,6 @@ function test()
function testHistoryDepth(next) function testHistoryDepth(next)
{ {
function dumpSimpleHistoryManagerState(title)
{
var simpleHistoryManager = historyManager._historyManager;
var entries = simpleHistoryManager._entries;
InspectorTest.addResult("=== SimpleHistoryManager state " + title + " ===");
InspectorTest.addResult("entries count: " + entries.length);
for (var i = entries.length - 1; i >= 0; --i) {
var position = entries[i]._positionHandle.resolve();
var positionText = position ? "{line: " + position.lineNumber + ", column: " + position.columnNumber + "}" : position + "";
var positionMarker = simpleHistoryManager._activeEntryIndex === i ? ">" : " ";
InspectorTest.addResult(positionMarker + "entry[" + i + "] = " + positionText);
}
InspectorTest.addResult("=== ===");
}
var lines = []; var lines = [];
var columns = []; var columns = [];
const jumpsAmount = WebInspector.EditingLocationHistoryManager.HistoryDepth; const jumpsAmount = WebInspector.EditingLocationHistoryManager.HistoryDepth;
...@@ -199,17 +185,8 @@ function test() ...@@ -199,17 +185,8 @@ function test()
columns.push(7); columns.push(7);
} }
var editor = panel.visibleView.textEditor; var editor = panel.visibleView.textEditor;
//FIXME(lushnikov): here and below excessive dumping to figure out a reason for
// unreproducible bot failures.
dumpSimpleHistoryManagerState("before filling history stack");
clickAndDump(editor, lines, columns); clickAndDump(editor, lines, columns);
dumpSimpleHistoryManagerState("after filling history stack"); for (var i = 0; i < jumpsAmount; ++i) {
InspectorTest.addResult("First rollback result: " + historyManager._historyManager.rollback());
dumpSimpleHistoryManagerState("after first rollback");
dumpSelection(editor, "Rolled back");
for (var i = 0; i < jumpsAmount - 1; ++i) {
rollback(); rollback();
dumpSelection(editor, "Rolled back"); dumpSelection(editor, "Rolled back");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment