Do not return a selected text marker range if there is no selection
We should not be returning a text marker range with NULL AXPositions whenever there is nothing selected on the webpage. Instead, like with all other text marker related attributes, we should return nil. Returning an AXRange with NULL AXPosition objects, makes VoiceOver hold onto and try to utilize NULL AXPositions in later API calls. Such API calls inevitably fail due to the fact that they are correctly considered invalid by our AXTextMarker deserialization logic. AX-Relnotes: n/a. R=abigailbklein@google.com, dmazzoni@chromium.org Change-Id: Iafa561e21f44a44deca4b5fa1e1d83ced02f1cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581298 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835175}
Showing
Please register or sign in to comment