Commit 91ac5f26 authored by Amr Aboelkher's avatar Amr Aboelkher Committed by Commit Bot

PSM: Integrate PSM unit tests set only

This CL add unit tests that tests all different scenarios that the
PSM can encounter. That doesn't include tests for PSM + hash dance.

See go/cros-psm-client-unittests-coverage for an overview of the
test cases for the different cases.

BUG=chromium:1136866

Change-Id: I69d16af68fecde5212f362f84ed5bbcb05a971e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461343
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: default avatarRoland Bock <rbock@google.com>
Reviewed-by: default avatarPavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824058}
parent 2b25c57f
......@@ -3989,7 +3989,10 @@ source_set("unit_tests") {
[ "//chromeos/services/chromebox_for_meetings/public/cpp:test_support" ]
}
data = [ "//chromeos/test/data/" ]
data = [
"//chromeos/test/data/",
"//third_party/private_membership/src/internal/testing/regression_test_data/cros_test_data.binarypb",
]
}
proto_library("attestation_proto") {
......
......@@ -1056,7 +1056,7 @@ bool AutoEnrollmentClientImpl::PrivateSetMembershipRetryStep() {
void AutoEnrollmentClientImpl::SetPrivateSetMembershipRlweClientForTesting(
std::unique_ptr<psm_rlwe::PrivateMembershipRlweClient>
private_set_membership_rlwe_client,
psm_rlwe::RlwePlaintextId& psm_rlwe_id) {
const psm_rlwe::RlwePlaintextId& psm_rlwe_id) {
if (!private_set_membership_helper_)
return;
......
......@@ -127,6 +127,14 @@ class AutoEnrollmentClientImpl
// network::NetworkConnectionTracker::NetworkConnectionObserver:
void OnConnectionChanged(network::mojom::ConnectionType type) override;
// Sets the private set membership RLWE client for testing through
// |private_set_membership_helper_|, if the protocol is enabled. Also, the
// |private_set_membership_rlwe_client| has to be non-null.
void SetPrivateSetMembershipRlweClientForTesting(
std::unique_ptr<private_membership::rlwe::PrivateMembershipRlweClient>
private_set_membership_rlwe_client,
const private_membership::rlwe::RlwePlaintextId& psm_rlwe_id);
private:
typedef bool (AutoEnrollmentClientImpl::*RequestCompletionHandler)(
policy::DeviceManagementService::Job*,
......@@ -163,14 +171,6 @@ class AutoEnrollmentClientImpl
// that protocol is being started only one time.
bool PrivateSetMembershipRetryStep();
// Sets the private set membership RLWE client for testing through
// |private_set_membership_helper_|, if the protocol is enabled. Also, the
// |private_set_membership_rlwe_client| has to be non-null.
void SetPrivateSetMembershipRlweClientForTesting(
std::unique_ptr<private_membership::rlwe::PrivateMembershipRlweClient>
private_set_membership_rlwe_client,
private_membership::rlwe::RlwePlaintextId& psm_rlwe_id);
// Cleans up and invokes |progress_callback_|.
void ReportProgress(AutoEnrollmentState state);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment