Adding minidump creation when launching renderer process fails in appcontainer mode.

Also reenabled appcontainer for renderer and fixed policy use after free case.

BUG=468922,473715
R=cpu,jschuh@chromium.org, wfh

Review URL: https://codereview.chromium.org/1058373003

Cr-Commit-Position: refs/heads/master@{#324348}

content/browser/renderer_host/render_process_host_impl.cc

@@ -335,6 +335,20 @@ class RendererSandboxedProcessLauncherDelegate
                               bool* success) {
     AddBaseHandleClosePolicy(policy);
 
+    if (base::win::GetVersion() == base::win::VERSION_WIN8 ||
+        base::win::GetVersion() == base::win::VERSION_WIN8_1) {
+      // TODO(shrikant): Check if these constants should be different across
+      // various versions of Chromium code base or could be same.
+      // If there should be different SID per channel then move this code
+      // in chrome rather than content and assign SID based on
+      // VersionInfo::GetChannel().
+      const wchar_t kAppContainerSid[] =
+          L"S-1-15-2-3251537155-1984446955-2931258699-841473695-1938553385-"
+          L"924012148-129201922";
+
+      policy->SetLowBox(kAppContainerSid);
+    }
+
     GetContentClient()->browser()->PreSpawnRenderer(policy, success);
   }
 

content/common/sandbox_win.cc

@@ -8,6 +8,7 @@
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/debug/profiler.h"
 #include "base/files/file_util.h"
 #include "base/hash.h"
@@ -728,7 +729,6 @@ base::Process StartSandboxedProcess(
                cmd_line->GetCommandLineString().c_str(),
                policy, &temp_process_info);
   DWORD last_error = ::GetLastError();
-  policy->Release();
   base::win::ScopedProcessInformation target(temp_process_info);
 
   TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
@@ -745,10 +745,18 @@ base::Process StartSandboxedProcess(
                                       "Process.Sandbox.Lowbox.Launch.Error" :
                                       "Process.Sandbox.Launch.Error",
                                   last_error);
+      // Trigger a minidump without crashing the browser.
+      // Note that this function will only generate minidump if content host
+      // has already done pre-setup by calling
+      // base::debug::SetDumpWithoutCrashingFunction
+      base::debug::DumpWithoutCrashing();
     } else
       DLOG(ERROR) << "Failed to launch process. Error: " << result;
+
+    policy->Release();
     return base::Process();
   }
+  policy->Release();
 
   if (delegate)
     delegate->PostSpawnTarget(target.process_handle());