Commit 9204e12c authored by Alex Gough's avatar Alex Gough Committed by Commit Bot

Use ReadOnlyFile in unzip service

Input zip files do not need to be written, and are opened read only, e.g.
https://source.chromium.org/chromium/chromium/src/+/master:components/services/unzip/public/cpp/unzip.cc;l=109

Bug: 1130762
Change-Id: I161ea1debe3b6ba7bf3a9f002bdb135be739eb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488399Reviewed-by: default avatarJoshua Pawlicki <waffles@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819419}
parent 1ea0b583
......@@ -5,8 +5,8 @@
module unzip.mojom;
import "components/services/filesystem/public/mojom/directory.mojom";
import "mojo/public/mojom/base/file.mojom";
import "mojo/public/mojom/base/file_path.mojom";
import "mojo/public/mojom/base/read_only_file.mojom";
interface UnzipFilter {
[Sync]
......@@ -16,14 +16,14 @@ interface UnzipFilter {
interface Unzipper {
// Unzip |zip_file| into |output_dir|.
// Returns true on success, false otherwise.
Unzip(mojo_base.mojom.File zip_file,
Unzip(mojo_base.mojom.ReadOnlyFile zip_file,
pending_remote<filesystem.mojom.Directory> output_dir)
=> (bool result);
// Same as |unzip| but only includes the files for which |filter| returns
// true. Note that this incurs one IPC for each file of the archive.
UnzipWithFilter(
mojo_base.mojom.File zip_file,
mojo_base.mojom.ReadOnlyFile zip_file,
pending_remote<filesystem.mojom.Directory> output_dir,
pending_remote<UnzipFilter> filter) => (bool result);
};
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment