Commit 9207cc1c authored by James Cook's avatar James Cook Committed by Commit Bot

cros/linux: Enable breakpad for utility processes

We get utility process crashes on Windows (via Crashpad) but we
don't get them on Linux or Chrome OS (via Breakpad). Enable breakpad
for utility processes as well.

utility process, see crash uploader logging its upload attempt

Bug: 776022
Test: run chrome --enable-crash-reporting-for-testing and crash the
Change-Id: Iaaec05ab856bb1c2515e0798a7c2caf6adacc5d3
Reviewed-on: https://chromium-review.googlesource.com/726852Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Reviewed-by: default avatarJay Civelli <jcivelli@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510113}
parent 2def61db
......@@ -138,5 +138,6 @@ bool ChromeCrashReporterClient::EnableBreakpadForProcess(
return process_type == switches::kRendererProcess ||
process_type == switches::kPpapiPluginProcess ||
process_type == switches::kZygoteProcess ||
process_type == switches::kGpuProcess;
process_type == switches::kGpuProcess ||
process_type == switches::kUtilityProcess;
}
......@@ -613,6 +613,13 @@ int GetCrashSignalFD(const base::CommandLine& command_line) {
return crash_handler->GetDeathSignalSocket();
}
if (process_type == switches::kUtilityProcess) {
static breakpad::CrashHandlerHostLinux* crash_handler = nullptr;
if (!crash_handler)
crash_handler = CreateCrashHandlerHost(process_type);
return crash_handler->GetDeathSignalSocket();
}
return -1;
}
#endif // defined(OS_POSIX) && !defined(OS_ANDROID) && !defined(OS_MACOSX)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment