Commit 9210616d authored by Changwan Ryu's avatar Changwan Ryu Committed by Commit Bot

Fortify autofill tests for WebView

Currently, we are testing whether certain callbacks are called / not
called in specific situations. This type of one-off tests are easily
isolatable, but it has its own limits - it is difficult to detect newly
added callbacks.

The new scheme audits all the calls into AutofillManager and ensures
that WebView autofill functionalities can work as expected.

Also, this CL refactors out some variables from TestAwAutofillManager
(renamed from AwAutofillManagerHelper) into AwAutofillTest and make
the test manager a thin wrapper.

Note: All the tests were run locally, as there is no trybot for O.

BUG=717658

Change-Id: Idacea03727f5f1cd56cd62dc1420dc74f48b04cf
Reviewed-on: https://chromium-review.googlesource.com/706379Reviewed-by: default avatarTao Bai <michaelbai@chromium.org>
Reviewed-by: default avatarYoland Yan <yolandyan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509690}
parent 93c331c2
...@@ -141,6 +141,7 @@ instrumentation_test_apk("webview_instrumentation_test_apk") { ...@@ -141,6 +141,7 @@ instrumentation_test_apk("webview_instrumentation_test_apk") {
"../javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java", "../javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java",
"../javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java", "../javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java",
"../javatests/src/org/chromium/android_webview/test/ArchiveTest.java", "../javatests/src/org/chromium/android_webview/test/ArchiveTest.java",
"../javatests/src/org/chromium/android_webview/test/AwActivityTestRule.java",
"../javatests/src/org/chromium/android_webview/test/AwAutofillTest.java", "../javatests/src/org/chromium/android_webview/test/AwAutofillTest.java",
"../javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java", "../javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java",
"../javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java", "../javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java",
...@@ -174,7 +175,6 @@ instrumentation_test_apk("webview_instrumentation_test_apk") { ...@@ -174,7 +175,6 @@ instrumentation_test_apk("webview_instrumentation_test_apk") {
"../javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java", "../javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java",
"../javatests/src/org/chromium/android_webview/test/AwSettingsTest.java", "../javatests/src/org/chromium/android_webview/test/AwSettingsTest.java",
"../javatests/src/org/chromium/android_webview/test/AwStrictModeTest.java", "../javatests/src/org/chromium/android_webview/test/AwStrictModeTest.java",
"../javatests/src/org/chromium/android_webview/test/AwActivityTestRule.java",
"../javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java", "../javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java",
"../javatests/src/org/chromium/android_webview/test/AwZoomTest.java", "../javatests/src/org/chromium/android_webview/test/AwZoomTest.java",
"../javatests/src/org/chromium/android_webview/test/CleanupReferenceTest.java", "../javatests/src/org/chromium/android_webview/test/CleanupReferenceTest.java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment