Commit 921ef392 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Passwords] Enable SaveUpdate bubble unit test HasTitleAndTwoButtons

As per the linked bug, tests in
PasswordSaveUpdateWithAccountStoreViewTest falkily timeout.
They have been however doing well for like 2 weeks before getting flaky.

I am considering enabling one of the simple test again to see if the
problem still exists or not.

Change-Id: I1452e7ee7e70ec7b3d63289527b4ae2134d4e81a
Bug: 1054629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073881Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744981}
parent 5859750f
...@@ -135,9 +135,7 @@ void PasswordSaveUpdateWithAccountStoreViewTest::CreateViewAndShow() { ...@@ -135,9 +135,7 @@ void PasswordSaveUpdateWithAccountStoreViewTest::CreateViewAndShow() {
views::BubbleDialogDelegateView::CreateBubble(view_)->Show(); views::BubbleDialogDelegateView::CreateBubble(view_)->Show();
} }
// TODO(crbug.com/1054629): Flakily times out on all platforms. TEST_F(PasswordSaveUpdateWithAccountStoreViewTest, HasTitleAndTwoButtons) {
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest,
DISABLED_HasTitleAndTwoButtons) {
CreateViewAndShow(); CreateViewAndShow();
EXPECT_TRUE(view()->ShouldShowWindowTitle()); EXPECT_TRUE(view()->ShouldShowWindowTitle());
EXPECT_TRUE(view()->GetOkButton()); EXPECT_TRUE(view()->GetOkButton());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment