Commit 921f26ad authored by James Cook's avatar James Cook Committed by Commit Bot

SplitSettings: Fix accessibility labels for browser settings banner

The link icon is presentational, so take it out of the tab order.
Add an aria-label to the clear button.

This is needed to get a11y browser tests to pass when we flip the
SplitSettings flag.

Bug: 950007
Test: enable Chromevox, tab through settings
Change-Id: Id5be0809de94f4107231f5a7f4d932e5cb143479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739392
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: default avatarMay Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684395}
parent c9c8494e
...@@ -106,12 +106,16 @@ ...@@ -106,12 +106,16 @@
<div id="browserSettingsBanner" class="settings-box banner"> <div id="browserSettingsBanner" class="settings-box banner">
<div class="start"> <div class="start">
<span>$i18nRaw{browserSettingsBannerText}</span> <span>$i18nRaw{browserSettingsBannerText}</span>
<a href="chrome://settings" target="_blank"> <!-- Use role="presentation" because the <span> has an accessible
link to settings.-->
<a href="chrome://settings" target="_blank"
tabindex="-1" role="presentation">
<iron-icon id="openInNewBrowserSettingsIcon" <iron-icon id="openInNewBrowserSettingsIcon"
icon="cr:open-in-new"></iron-icon> icon="cr:open-in-new"></iron-icon>
</a> </a>
</div> </div>
<cr-icon-button class="icon-clear" <cr-icon-button class="icon-clear"
aria-label="$i18n{clear}"
on-click="onHideBrowserSettingsBannerClick_"> on-click="onHideBrowserSettingsBannerClick_">
</cr-icon-button> </cr-icon-button>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment