Commit 9248cf3e authored by Christian Biesinger's avatar Christian Biesinger Committed by Commit Bot

Remove google-gdb warning

GDB has been updated to version 8.1, so this should not be
necessary aymore.

Bug: 957374
Change-Id: Id372c263c73eb9447fde1ef68c1e31174875a22e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717240
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680631}
parent 9f1c196b
...@@ -81,21 +81,6 @@ def newobj_handler(event): ...@@ -81,21 +81,6 @@ def newobj_handler(event):
load_gdb_chrome(src_dir) load_gdb_chrome(src_dir)
lsb_release = subprocess.Popen(['lsb_release', '-sc'],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
codename = lsb_release.communicate()[0]
if codename.rstrip() == b'rodete' and 'gg' not in gdb.VERSION:
sys.stderr.write(
'\033[93mDetected gLinux without using google-gdb. google-gdb is '
'recommended because it is more up-to-date than the system gdb, which '
'has known issues (https://crbug.com/957374). To switch to google-gdb, '
'run "sudo apt install google-gdb" which will *uninstall* gdb and '
'*install* google-gdb. This is a drop-in replacement with the same '
'command line usage, so you can still run eg. '
'"gdb out/Debug/chrome".\033[0m\n'
)
# Event hook for newly loaded objfiles. # Event hook for newly loaded objfiles.
# https://sourceware.org/gdb/onlinedocs/gdb/Events-In-Python.html # https://sourceware.org/gdb/onlinedocs/gdb/Events-In-Python.html
gdb.events.new_objfile.connect(newobj_handler) gdb.events.new_objfile.connect(newobj_handler)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment