Refactor signed_exchange_subresource_prefetch_browsertest.cc

Bug: 935267
Change-Id: I8800a415c1fffd0e59d37f1a65d122d17ab5e6c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641017Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666161}

content/browser/loader/prefetch_browsertest_base.cc

@@ -30,8 +30,14 @@ PrefetchBrowserTestBase::ResponseEntry::ResponseEntry(
     const std::vector<std::pair<std::string, std::string>>& headers)
     : content(content), content_type(content_type), headers(headers) {}
 
+PrefetchBrowserTestBase::ResponseEntry::ResponseEntry(ResponseEntry&& other) =
+    default;
+
 PrefetchBrowserTestBase::ResponseEntry::~ResponseEntry() = default;
 
+PrefetchBrowserTestBase::ResponseEntry& PrefetchBrowserTestBase::ResponseEntry::
+operator=(ResponseEntry&& other) = default;
+
 PrefetchBrowserTestBase::ScopedSignedExchangeHandlerFactory::
     ScopedSignedExchangeHandlerFactory(SignedExchangeHandlerFactory* factory) {
   SignedExchangeLoader::SetSignedExchangeHandlerFactoryForTest(factory);
@@ -61,8 +67,8 @@ void PrefetchBrowserTestBase::SetUpOnMainThread() {
 }
 
 void PrefetchBrowserTestBase::RegisterResponse(const std::string& url,
-                                               const ResponseEntry& entry) {
-  response_map_[url] = entry;
+                                               ResponseEntry&& entry) {
+  response_map_[url] = std::move(entry);
 }
 
 std::unique_ptr<net::test_server::HttpResponse>

content/browser/loader/prefetch_browsertest_base.h

@@ -29,10 +29,14 @@ class PrefetchBrowserTestBase : public ContentBrowserTest {
  public:
   struct ResponseEntry {
     ResponseEntry();
-    explicit ResponseEntry(
+    ResponseEntry(
         const std::string& content,
         const std::string& content_types = "text/html",
         const std::vector<std::pair<std::string, std::string>>& headers = {});
+    ResponseEntry(const ResponseEntry&) = delete;
+    ResponseEntry(ResponseEntry&& other);
+    ResponseEntry& operator=(const ResponseEntry&) = delete;
+    ResponseEntry& operator=(ResponseEntry&&);
     ~ResponseEntry();
 
     std::string content;
@@ -52,7 +56,7 @@ class PrefetchBrowserTestBase : public ContentBrowserTest {
   void SetUpOnMainThread() override;
 
  protected:
-  void RegisterResponse(const std::string& url, const ResponseEntry& entry);
+  void RegisterResponse(const std::string& url, ResponseEntry&& entry);
 
   std::unique_ptr<net::test_server::HttpResponse> ServeResponses(
       const net::test_server::HttpRequest& request);