Commit 92671c7c authored by Hazem Ashmawy's avatar Hazem Ashmawy Committed by Commit Bot

[AW] DevUI: Remove variation keys from crash UI

Remove variation keys field from crash expandable list since it's mostly
a bunch of numbers and characters with no direct benefit for the user.

Note: that this only removes it from the UI, variation keys is still
part of CrashInfo class and still collected from crashpad and  written
to logs. They will be removed in a following CL.

Bug: 1052510
Test: Manually invoke crashes and observe the UI
Change-Id: If96f67595c5feacb731579fe1a26e92af4308048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095575Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749534}
parent 47190b2d
...@@ -19,9 +19,6 @@ ...@@ -19,9 +19,6 @@
android:paddingEnd="100dp" android:paddingEnd="100dp"
android:orientation="vertical"> android:orientation="vertical">
<include layout="@layout/two_line_sublist_item"
android:id="@+id/variations"/>
<include layout="@layout/two_line_sublist_item" <include layout="@layout/two_line_sublist_item"
android:id="@+id/upload_status"/> android:id="@+id/upload_status"/>
......
...@@ -215,7 +215,6 @@ public class CrashesListActivity extends Activity { ...@@ -215,7 +215,6 @@ public class CrashesListActivity extends Activity {
} }
// Child View where more info about the crash is shown: // Child View where more info about the crash is shown:
// - Variation keys for the crash.
// - Crash report upload status. // - Crash report upload status.
@Override @Override
public View getChildView(int groupPosition, final int childPosition, boolean isLastChild, public View getChildView(int groupPosition, final int childPosition, boolean isLastChild,
...@@ -227,25 +226,6 @@ public class CrashesListActivity extends Activity { ...@@ -227,25 +226,6 @@ public class CrashesListActivity extends Activity {
} }
CrashInfo crashInfo = (CrashInfo) getChild(groupPosition, childPosition); CrashInfo crashInfo = (CrashInfo) getChild(groupPosition, childPosition);
// Variations keys
View variationsView = view.findViewById(R.id.variations);
setTwoLineListItemText(variationsView, "Variations",
crashInfo.variations == null ? "Not available"
: crashInfo.variations.toString());
variationsView.setOnLongClickListener(v -> {
if (crashInfo.variations != null) {
ClipboardManager clipboard =
(ClipboardManager) getSystemService(Context.CLIPBOARD_SERVICE);
ClipData clip =
ClipData.newPlainText("variations", crashInfo.variations.toString());
clipboard.setPrimaryClip(clip);
// Show a toast that the text has been copied.
Toast.makeText(CrashesListActivity.this, "Copied variations keys",
Toast.LENGTH_SHORT)
.show();
}
return true;
});
// Upload info // Upload info
String uploadState = uploadStateString(crashInfo.uploadState); String uploadState = uploadStateString(crashInfo.uploadState);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment