Revert "v8binding: Stops using the copyable ver of v8::Persistent."
This reverts commit d4dd5c37. Reason for revert: Causes 40+ layout tests to leak, e.g. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/12726 Original change's description: > v8binding: Stops using the copyable ver of v8::Persistent. > > I learnt that v8::Persistent provides two variations of copying. > One actually copies, and the other actually shares the underlying > slot. > > This patch changes CallbackFunctionBase::Persistent from the > "share" version to the "copy" (= make another independent slot) > version. > > Bug: 779036 > Change-Id: I1fae7a1547af2abefa932458f398d8e2b50ecaa3 > Reviewed-on: https://chromium-review.googlesource.com/798820 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520528} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I15cccba7606269da57e4b3c48d8e9bfa3b1c103c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779036 Reviewed-on: https://chromium-review.googlesource.com/802715Reviewed-by:Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#520844}
Showing
Please register or sign in to comment