Commit 92a0dddb authored by prasadv@chromium.org's avatar prasadv@chromium.org

On Windows XP platform, don't run GOMA service.

For Windows XP platforms, GOMA service is not supported.
Moreover we don't compile chorme when gs_bucket flag is set instead use builds archives, therefore ignore GOMA service for Windows XP.

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/255963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266446 0039d316-1c4b-4281-b951-d872f2087c98
parent 418e5df5
......@@ -15,6 +15,7 @@ directory provided, and run the bisect-perf-regression.py script there.
import imp
import optparse
import os
import platform
import subprocess
import sys
import traceback
......@@ -388,6 +389,13 @@ def _RunBisectionScript(config, working_directory, path_to_file, path_to_goma,
cmd.extend(['--target_platform', 'android'])
if path_to_goma:
# crbug.com/330900. For Windows XP platforms, GOMA service is not supported.
# Moreover we don't compile chrome when gs_bucket flag is set instead
# use builds archives, therefore ignore GOMA service for Windows XP.
if config.get('gs_bucket') and platform.release() == 'XP':
print ('Goma doesn\'t have a win32 binary, therefore it is not supported '
'on Windows XP platform. Please refer to crbug.com/330900.')
path_to_goma = None
cmd.append('--use_goma')
if path_to_extra_src:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment