Revert of Mac: Update sheet position when bookmark bar is shown or hidden....
Revert of Mac: Update sheet position when bookmark bar is shown or hidden. (patchset #1 id:1 of https://codereview.chromium.org/502413004/) Reason for revert: Broke certificate info positioning when switching tabs (http://crbug.com/419371). I will need to come up with a better fix for this, but it looks complicated and that bug is a M39 stable blocker so reverting this first. Original issue's description: > Mac: Update sheet position when bookmark bar is shown or hidden. > > In r272421, I changed sheet repositioning on window resize to be based on > NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification > because it tracks window resizing much more smoothly. > > That caused this problem where if the browser window is vertically maximized > (or is in fullscreen), the window size does not change when the bookmark bar > is shown or hidden. > > The old code has a different bug however. If the browser window is not > vertically maximized, showing or hiding the bookmark bar does not change the > browser content view's frame. It moves up or down to follow the window resize > but its frame relative to its superview remains the same. > > I settled for adding code to explicitly update the sheet's position when the > bookmark bar is shown or hidden. > > BUG=407509 > > Committed: https://crrev.com/5648b809d1c50e3de754b96abe7cf2b60150ff4d > Cr-Commit-Position: refs/heads/master@{#292421} TBR=avi@chromium.org BUG=407509 Review URL: https://codereview.chromium.org/653733002 Cr-Commit-Position: refs/heads/master@{#299391}
Showing
Please register or sign in to comment