feedback: Apply an aria label to the screenshot.

Right now, the feedback doesn't have any label at all and is read as
"image" by ChromeVox.

BUG=chromium:1005521
TEST=Loaded onto an eve with chromevox, observed correct description.

Change-Id: Idfd8f2946dbfaf3929b095bbc914a4954afcf6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864093
Commit-Queue: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707423}

chrome/app/generated_resources.grd

@@ -5838,6 +5838,9 @@ the Bookmarks menu.">
         <message name="IDS_FEEDBACK_SCREENSHOT_LABEL" desc="Label for the screenshot field if current screenshots are being shown">
           Include this screenshot
         </message>
+        <message name="IDS_FEEDBACK_SCREENSHOT_A11Y_TEXT" desc="Accessibility label text for screenshot of system, which shows contents of screen apart from feedback dialog">
+          Screenshot of programs that are currently on the screen
+        </message>
         <message name="IDS_FEEDBACK_INCLUDE_PERFORMANCE_TRACE_CHECKBOX" desc="Checkbox for including system performance data on the bug report dialog box">
           Send performance trace data
         </message>

chrome/app/generated_resources_grd/IDS_FEEDBACK_SCREENSHOT_ALT_TEXT.png.sha1

+ce7547b911affc1addcd31a63680bfee1fd57bcd
\ No newline at end of file

chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc

@@ -77,6 +77,7 @@ ChromeFeedbackPrivateDelegate::GetStrings(
   SET_STRING("close-btn-label", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);
   SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);
   SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);
+  SET_STRING("screenshotA11y", IDS_FEEDBACK_SCREENSHOT_A11Y_TEXT);
   SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);
   SET_STRING("anonymous-user", IDS_FEEDBACK_ANONYMOUS_EMAIL_OPTION);
   SET_STRING("sys-info", GetSysInfoCheckboxStringId(browser_context));

chrome/browser/resources/feedback/css/feedback.css

@@ -140,7 +140,7 @@ body {
   width: 200px;
 }
 
-.content #screenshot-label {
+.content #screenshot-chk-label {
   flex: auto;
 }
 

chrome/browser/resources/feedback/html/default.html

@@ -59,9 +59,10 @@
     <div id="attach-file-note" i18n-content="attach-file-note"></div>
     <!-- Screenshot -->
     <div id="screenshot-container" class="checkbox-field-container">
-      <input id="screenshot-checkbox" type="checkbox" aria-labelledby="screenshot-label">
-      <label id="screenshot-label" i18n-content="screenshot"></label>
-      <img id="screenshot-image">
+      <input id="screenshot-checkbox" type="checkbox"
+             aria-labelledby="screenshot-chk-label">
+      <label id="screenshot-chk-label" i18n-content="screenshot"></label>
+      <img id="screenshot-image" i18n-values="aria-label:screenshotA11y">
     </div>
     <!-- System Information -->
     <div id="sys-info-container" class="checkbox-field-container">