Skip to content

GitLab

T
tangled
Commit 92f861e1 authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot
Browse files
Options

Remove ExtraWebGLVideoTextureMetadata from experimental features. 

This code path de-duplicates video uploads to textures, but something
is wrong with the de-duplication logic and it's causing video frames
to sometimes not be uploaded when they need to be.

The WebGL conformance tests run on the waterfall with
--enable-experimental-web-platform-features in order to exercise
some upcoming features, but this particular one must be disabled for
reliable test execution.

This experiment can be manually enabled with the command line flag
--enable-blink-features=ExtraWebGLVideoTextureMetadata .

Moved the layout test verifying this functionality into its own
virtual test suite.

Bug: 830901
Change-Id: Ic7bc75cd71f6a8d74ce85ded6153fb9782f73eb6
Reviewed-on: https://chromium-review.googlesource.com/c/1264542
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarKai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597379}
parent 289fe5e7
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 21 deletions
third_party/WebKit/LayoutTests/NeverFixTests
View file @ 92f861e1
......@@ -1930,3 +1930,6 @@ crbug.com/870172 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-whi
crbug.com/870172 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-whitelisting-exact-match.html [ WontFix ]
crbug.com/870172 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-whitelisting-subdomains.html [ WontFix ]
crbug.com/870172 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html [ WontFix ]
# Not expected to pass in default configuration, only virtual test suite.
crbug.com/830901 fast/webgl/video-metadata/texImage-video-last-uploaded-metadata.html [ WontFix ]
third_party/WebKit/LayoutTests/VirtualTestSuites
View file @ 92f861e1
......@@ -768,5 +768,10 @@
"prefix": "display-lock",
"base": "display-lock",
"args": ["--enable-blink-features=DisplayLocking"]
},
{
"prefix": "webgl-extra-video-texture-metadata",
"base": "fast/webgl/video-metadata",
"args": ["--enable-blink-features=ExtraWebGLVideoTextureMetadata"]
}
]
third_party/WebKit/LayoutTests/fast/webgl/texImage-video-last-uploaded-metadata.html → third_party/WebKit/LayoutTests/fast/webgl/video-metadata/texImage-video-last-uploaded-metadata.html
View file @ 92f861e1
<!DOCTYPE html>
<html>
<head>
<script src="./resources/webgl-test-utils-full.js"></script>
<script src="./resources/tex-image-and-sub-image-utils.js"></script>
<script src="../../resources/js-test.js"></script>
<script src="../resources/webgl-test-utils-full.js"></script>
<script src="../resources/tex-image-and-sub-image-utils.js"></script>
<script src="../../../resources/js-test.js"></script>
<script>
window.jsTestIsAsync = true;
......@@ -51,7 +51,7 @@ function init()
video.oncanplaythrough = runTest;
video.currentTime = 2.0;
};
video.src = "./resources/red-green.ogv";
video.src = "../resources/red-green.ogv";
}
</script>
</head>
......
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
View file @ 92f861e1
......@@ -3371,10 +3371,6 @@ interface WebGLSync
method constructor
interface WebGLTexture
attribute @@toStringTag
getter lastUploadedVideoFrameWasSkipped
getter lastUploadedVideoHeight
getter lastUploadedVideoTimestamp
getter lastUploadedVideoWidth
method constructor
interface WebGLTransformFeedback
attribute @@toStringTag
......
third_party/WebKit/LayoutTests/virtual/webgl-extra-video-texture-metadata/fast/webgl/video-metadata/README.txt 0 → 100644
View file @ 92f861e1
Runs a minimal set of layout tests with Blink's
ExtraWebGLVideoTextureMetadata run-time flag enabled. crbug.com/830901
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
View file @ 92f861e1
......@@ -3396,10 +3396,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method constructor
[Worker] interface WebGLTexture
[Worker] attribute @@toStringTag
[Worker] getter lastUploadedVideoFrameWasSkipped
[Worker] getter lastUploadedVideoHeight
[Worker] getter lastUploadedVideoTimestamp
[Worker] getter lastUploadedVideoWidth
[Worker] method constructor
[Worker] interface WebGLTransformFeedback
[Worker] attribute @@toStringTag
......
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
View file @ 92f861e1
......@@ -9938,10 +9938,6 @@ interface WebGLSync
method constructor
interface WebGLTexture
attribute @@toStringTag
getter lastUploadedVideoFrameWasSkipped
getter lastUploadedVideoHeight
getter lastUploadedVideoTimestamp
getter lastUploadedVideoWidth
method constructor
interface WebGLTransformFeedback
attribute @@toStringTag
......
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
View file @ 92f861e1
......@@ -3277,10 +3277,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method constructor
[Worker] interface WebGLTexture
[Worker] attribute @@toStringTag
[Worker] getter lastUploadedVideoFrameWasSkipped
[Worker] getter lastUploadedVideoHeight
[Worker] getter lastUploadedVideoTimestamp
[Worker] getter lastUploadedVideoWidth
[Worker] method constructor
[Worker] interface WebGLTransformFeedback
[Worker] attribute @@toStringTag
......
third_party/blink/renderer/platform/runtime_enabled_features.json5
View file @ 92f861e1
......@@ -466,7 +466,6 @@
},
{
name: "ExtraWebGLVideoTextureMetadata",
status: "experimental",
},
{
name: "FastMobileScrolling",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment