Commit 930833ce authored by Mirko Bonadei's avatar Mirko Bonadei Committed by Commit Bot

Fix public_deps on compression_utils_portable.

As compression_utils_portable is been used by client code instead
of only internally in zlib helpers, there is the need to properly
export the right flags (i.e. header include paths) as some OSes
(e.g. Fuchsia) may have issues properly building/linking with zlib.

Bug: 1076580, 1087999
Change-Id: Ic54a55db40301dead92402e05c5da5613eb29c95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228311Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774767}
parent f9b9e9d2
......@@ -35,15 +35,6 @@ if (build_with_chromium) {
}
}
# It seems that Fuchsia bot will fail to build if we don't explicitly
# add this config as part of utils_portable.
config("zlib_portable_utils_config") {
include_dirs = [
"//third_party/zlib",
"//third_party/zlib/google",
]
}
# This allows other users of Chromium's zlib library, but don't use Chromium's
# //base, to reuse some boilerplate code.
static_library("compression_utils_portable") {
......@@ -51,6 +42,5 @@ static_library("compression_utils_portable") {
"compression_utils_portable.cc",
"compression_utils_portable.h",
]
deps = [ "//third_party/zlib" ]
public_configs = [ ":zlib_portable_utils_config" ]
public_deps = [ "//third_party/zlib" ]
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment