Skip to content

GitLab

T
tangled
Commit 93198017 authored by kouhei's avatar kouhei Committed by Commit bot
Browse files
Options

A frameset tag inside template should be simply ignored. 

As stated in the spec, <template> tag start token should set frameset-ok
flag to false when in in-body/in-head insertion mode.
https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody

BUG=475002

Review-Url: https://codereview.chromium.org/2135203002
Cr-Commit-Position: refs/heads/master@{#404632}
parent c4b85f71
Hide whitespace changes
Inline Side-by-side
Showing with 20 additions and 0 deletions
third_party/WebKit/LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template.html 0 → 100644
View file @ 93198017
<!doctype html>
<link rel=help href="https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inhead">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<body>
<script>
var test = async_test("A frameset tag inside template should be simply ignored.");
var iframe = document.createElement("iframe");
iframe.onload = function() {
document.body.removeChild(iframe);
test.done();
};
iframe.src = './resources/frameset-inside-template.html';
document.body.appendChild(iframe);
</script>
third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
View file @ 93198017
...@@ -911,6 +911,7 @@ void HTMLTreeBuilder::processTemplateStartTag(AtomicHTMLToken* token) ...@@ -911,6 +911,7 @@ void HTMLTreeBuilder::processTemplateStartTag(AtomicHTMLToken* token)
{ {
m_tree.activeFormattingElements()->appendMarker(); m_tree.activeFormattingElements()->appendMarker();
m_tree.insertHTMLElement(token); m_tree.insertHTMLElement(token);
m_framesetOk = false;
m_templateInsertionModes.append(TemplateContentsMode); m_templateInsertionModes.append(TemplateContentsMode);
setInsertionMode(TemplateContentsMode); setInsertionMode(TemplateContentsMode);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment