Commit 931f6268 authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Commit Bot

Android: Display image title in Ephemeral Tab

Uses image src url if alt text is missing. This is how
image opened in a new tab works.

Bug: 960130
Change-Id: Id592a091c445486f8ee81e4d7090366f5719301c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605380Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659302}
parent 00a22d98
......@@ -11,6 +11,7 @@ import android.text.TextUtils;
import android.util.Pair;
import android.view.ContextMenu;
import android.webkit.MimeTypeMap;
import android.webkit.URLUtil;
import org.chromium.base.library_loader.LibraryProcessType;
import org.chromium.base.metrics.RecordHistogram;
......@@ -431,7 +432,11 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
mDelegate.onOpenImageInNewTab(params.getSrcUrl(), params.getReferrer());
} else if (itemId == R.id.contextmenu_open_image_in_ephemeral_tab) {
ContextMenuUma.record(params, ContextMenuUma.Action.OPEN_IMAGE_IN_EPHEMERAL_TAB);
mDelegate.onOpenInEphemeralTab(params.getSrcUrl(), params.getTitleText());
String title = params.getTitleText();
if (TextUtils.isEmpty(title)) {
title = URLUtil.guessFileName(params.getSrcUrl(), null, null);
}
mDelegate.onOpenInEphemeralTab(params.getSrcUrl(), title);
} else if (itemId == R.id.contextmenu_load_original_image) {
ContextMenuUma.record(params, ContextMenuUma.Action.LOAD_ORIGINAL_IMAGE);
DataReductionProxyUma.previewsLoFiContextMenuAction(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment