Commit 936d0343 authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

[RTCInsertableStreams] Enable by default

The runtime flag remains for the legacy API, which
will continue as an origin trial and will be removed
later.

Intent to ship:
https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/XFO4OXrdSRA

Intent to experiment for legacy API:
https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/LLtmsTDMnXg

Bug: 1059912
Change-Id: I65d3ecf490fb6b0e229b7ee4c153c2f541a3c6c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367063Reviewed-by: default avatarRick Byers <rbyers@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800258}
parent 4daa9ff9
......@@ -54,7 +54,7 @@ dictionary RTCConfiguration {
[RuntimeEnabled=RtcAudioJitterBufferMaxPackets] long rtcAudioJitterBufferMaxPackets;
[RuntimeEnabled=RtcAudioJitterBufferMaxPackets] boolean rtcAudioJitterBufferFastAccelerate;
[RuntimeEnabled=RtcAudioJitterBufferMaxPackets] long rtcAudioJitterBufferMinDelayMs;
[RuntimeEnabled=RTCInsertableStreams] boolean encodedInsertableStreams = false;
boolean encodedInsertableStreams = false;
[DeprecateAs=ForceEncodedAudioInsertableStreams,
RuntimeEnabled=RTCInsertableStreams] boolean forceEncodedAudioInsertableStreams = false;
[DeprecateAs=ForceEncodedVideoInsertableStreams,
......
......@@ -7,16 +7,15 @@
// TODO(crbug.com/1052765): Align with WebCodecs definition once it is stable.
[
Exposed=Window,
RuntimeEnabled=RTCInsertableStreams
Exposed=Window
] interface RTCEncodedAudioFrame {
readonly attribute unsigned long long timestamp; // microseconds
attribute ArrayBuffer data;
RTCEncodedAudioFrameMetadata getMetadata();
// TODO(crbug.com/1052765): Remove the following fields before enabling
// by default.
readonly attribute ArrayBuffer additionalData;
readonly attribute unsigned long synchronizationSource;
readonly attribute FrozenArray<unsigned long> contributingSources;
[RuntimeEnabled=RTCInsertableStreams] readonly attribute ArrayBuffer additionalData;
[RuntimeEnabled=RTCInsertableStreams] readonly attribute unsigned long synchronizationSource;
[RuntimeEnabled=RTCInsertableStreams] readonly attribute FrozenArray<unsigned long> contributingSources;
stringifier;
};
......@@ -13,8 +13,7 @@ enum RTCEncodedVideoFrameType {
// TODO(crbug.com/1052765): Align with WebCodecs definition once it is stable.
[
Exposed=Window,
RuntimeEnabled=RTCInsertableStreams
Exposed=Window
] interface RTCEncodedVideoFrame {
readonly attribute RTCEncodedVideoFrameType type;
readonly attribute unsigned long long timestamp; // microseconds
......@@ -22,7 +21,7 @@ enum RTCEncodedVideoFrameType {
RTCEncodedVideoFrameMetadata getMetadata();
// TODO(crbug.com/1052765): Remove the following fields before enabling
// by default.
readonly attribute ArrayBuffer additionalData;
readonly attribute unsigned long synchronizationSource;
[RuntimeEnabled=RTCInsertableStreams] readonly attribute ArrayBuffer additionalData;
[RuntimeEnabled=RTCInsertableStreams] readonly attribute unsigned long synchronizationSource;
stringifier;
};
......@@ -15,7 +15,7 @@ interface RTCRtpReceiver {
[CallWith=ScriptState, RaisesException] sequence<RTCRtpSynchronizationSource> getSynchronizationSources();
[CallWith=ScriptState, RaisesException] sequence<RTCRtpContributingSource> getContributingSources();
[CallWith=ScriptState] Promise<RTCStatsReport> getStats();
[Measure, RuntimeEnabled=RTCInsertableStreams,
[Measure,
CallWith=ScriptState,
RaisesException] RTCInsertableStreams createEncodedStreams();
[DeprecateAs=V8RTCRtpReceiver_CreateEncodedAudioStreams_Method,
......
......@@ -16,7 +16,6 @@ interface RTCRtpSender {
[Measure, RaisesException] void setStreams(MediaStream... streams);
[CallWith=ScriptState] Promise<RTCStatsReport> getStats();
[Measure,
RuntimeEnabled=RTCInsertableStreams,
CallWith=ScriptState,
RaisesException] RTCInsertableStreams createEncodedStreams();
[DeprecateAs=V8RTCRtpSender_CreateEncodedAudioStreams_Method,
......
......@@ -1621,7 +1621,8 @@
origin_trial_feature_name: "RTCQuicTransport",
status: "experimental",
},
// Enables the use of Insertable Streams.
// Enables the use of the Insertable Streams legacy API.
// TODO(https://crbug.com/1119801): Remove when the origin trial ends.
{
name: "RTCInsertableStreams",
origin_trial_feature_name: "RTCInsertableStreams",
......
......@@ -5333,6 +5333,23 @@ interface RTCDtlsTransport : EventTarget
method getRemoteCertificates
setter onerror
setter onstatechange
interface RTCEncodedAudioFrame
attribute @@toStringTag
getter data
getter timestamp
method constructor
method getMetadata
method toString
setter data
interface RTCEncodedVideoFrame
attribute @@toStringTag
getter data
getter timestamp
getter type
method constructor
method getMetadata
method toString
setter data
interface RTCError : DOMException
attribute @@toStringTag
getter errorDetail
......@@ -5462,6 +5479,7 @@ interface RTCRtpReceiver
getter track
getter transport
method constructor
method createEncodedStreams
method getContributingSources
method getParameters
method getStats
......@@ -5475,6 +5493,7 @@ interface RTCRtpSender
getter track
getter transport
method constructor
method createEncodedStreams
method getParameters
method getStats
method replaceTrack
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment