Commit 938e803e authored by horo's avatar horo Committed by Commit bot

[1/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

This cl implements ServiceWorkerHandler::ActivateTarget() to focus the tab which is controlled by ServiceWorker.

Screenshot: https://code.google.com/p/chromium/issues/detail?id=466871#c65

1/5 chromium: This cl.
2/5 blink: https://codereview.chromium.org/1151993003/
3/5 chromium: https://codereview.chromium.org/1149383004/
4/5 blink: https://codereview.chromium.org/1164583002/
5/5 chromium: https://codereview.chromium.org/1143363009/

BUG=466871

Review URL: https://codereview.chromium.org/1160133002

Cr-Commit-Position: refs/heads/master@{#333671}
parent 96a82476
...@@ -397,6 +397,20 @@ Response ServiceWorkerHandler::DeliverPushMessage( ...@@ -397,6 +397,20 @@ Response ServiceWorkerHandler::DeliverPushMessage(
return Response::OK(); return Response::OK();
} }
Response ServiceWorkerHandler::GetTargetInfo(DevToolsCommandId command_id,
const std::string& target_id) {
return Response::InternalError("Not implemented yet");
}
Response ServiceWorkerHandler::ActivateTarget(const std::string& target_id) {
scoped_refptr<DevToolsAgentHost> agent_host(
DevToolsAgentHost::GetForId(target_id));
if (!agent_host)
return Response::InvalidParams("targetId");
agent_host->Activate();
return Response::OK();
}
void ServiceWorkerHandler::OpenNewDevToolsWindow(int process_id, void ServiceWorkerHandler::OpenNewDevToolsWindow(int process_id,
int devtools_agent_route_id) { int devtools_agent_route_id) {
scoped_refptr<DevToolsAgentHostImpl> agent_host( scoped_refptr<DevToolsAgentHostImpl> agent_host(
......
...@@ -59,6 +59,9 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient, ...@@ -59,6 +59,9 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
Response DeliverPushMessage(const std::string& origin, Response DeliverPushMessage(const std::string& origin,
const std::string& registration_id, const std::string& registration_id,
const std::string& data); const std::string& data);
Response GetTargetInfo(DevToolsCommandId command_id,
const std::string& target_id);
Response ActivateTarget(const std::string& target_id);
// WorkerDevToolsManager::Observer implementation. // WorkerDevToolsManager::Observer implementation.
void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override; void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment