[AW][Dev-UI] fix lint issues

This fixes lint issues in Dev UI code. The only logic change is we're
now calling super.onNewIntent().

Bug: 1107950
Test: autoninja -C out/Default system_webview_apk
Test: manually verify Dev UI navigation looks right
Change-Id: Ia70e8c843bbb2ceb4e0052f530496cc26dd38325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310871Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790592}

android_webview/nonembedded/java/src/org/chromium/android_webview/devui/MainActivity.java

@@ -49,7 +49,7 @@ public class MainActivity extends FragmentActivity {
     // These values are persisted to logs. Entries should not be renumbered and
     // numeric values should never be reused.
     @IntDef({MenuChoice.SWITCH_PROVIDER, MenuChoice.REPORT_BUG, MenuChoice.CHECK_UPDATES,
-            MenuChoice.CRASHES_REFRESH})
+            MenuChoice.CRASHES_REFRESH, MenuChoice.ABOUT_DEVTOOLS})
     public @interface MenuChoice {
         int SWITCH_PROVIDER = 0;
         int REPORT_BUG = 1;
@@ -205,6 +205,7 @@ public class MainActivity extends FragmentActivity {
 
     @Override
     protected void onNewIntent(Intent intent) {
+        super.onNewIntent(intent);
         // Store the Intent so we can switch Fragments in onResume (which is called next). Only need
         // to switch Fragment if the Intent specifies to do so.
         setIntent(intent);

build/android/lint/baseline.xml

@@ -34,17 +34,6 @@
             column="17"/>
     </issue>
 
-    <issue
-        id="MissingSuperCall"
-        message="Overriding method should call `super.onNewIntent`"
-        errorLine1="    protected void onNewIntent(Intent intent) {"
-        errorLine2="                   ~~~~~~~~~~~">
-        <location
-            file="android_webview/nonembedded/java/src/org/chromium/android_webview/devui/MainActivity.java"
-            line="207"
-            column="20"/>
-    </issue>
-
     <issue
         id="ResourceType"
         message="Expected a color resource id (`R.color.`) but received an RGB integer"
@@ -401,17 +390,6 @@
             column="50"/>
     </issue>
 
-    <issue
-        id="WrongConstant"
-        message="Must be one of: MenuChoice.SWITCH_PROVIDER, MenuChoice.REPORT_BUG, MenuChoice.CHECK_UPDATES, MenuChoice.CRASHES_REFRESH"
-        errorLine1="            logMenuSelection(MenuChoice.ABOUT_DEVTOOLS);"
-        errorLine2="                             ~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="android_webview/nonembedded/java/src/org/chromium/android_webview/devui/MainActivity.java"
-            line="293"
-            column="30"/>
-    </issue>
-
     <issue
         id="WrongConstant"
         message="Must be one of: Type.NO_ADJUSTMENT, Type.FRAMERATE_ADJUSTMENT"