Commit 93a51b5b authored by Sam McNally's avatar Sam McNally Committed by Commit Bot

Remove logging of fileManagerPrivate API calls that never fail.

getDriveConnectionState, getPreferences and setPreferences can never
fail, yet log when they succeed. This logging is noisy and distracts
from logging of other API calls so remove it.

Bug: 896123
Change-Id: I75f079a941df47c55bb7cbcbd8292b125f6472e6
Reviewed-on: https://chromium-review.googlesource.com/c/1350016Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610763}
parent 94aad40b
......@@ -1450,10 +1450,6 @@ FileManagerPrivateGetDriveConnectionStateFunction::Run() {
->network_state_handler()
->FirstNetworkByType(chromeos::NetworkTypePattern::Mobile());
drive::EventLogger* logger = file_manager::util::GetLogger(
Profile::FromBrowserContext(browser_context()));
if (logger)
logger->Log(logging::LOG_INFO, "%s succeeded.", name());
return RespondNow(ArgumentList(
api::file_manager_private::GetDriveConnectionState::Results::Create(
result)));
......
......@@ -227,10 +227,6 @@ FileManagerPrivateGetPreferencesFunction::Run() {
base::UTF16ToUTF8(chromeos::system::TimezoneSettings::GetInstance()
->GetCurrentTimezoneID());
drive::EventLogger* logger = file_manager::util::GetLogger(profile);
if (logger)
logger->Log(logging::LOG_INFO, "%s succeeded.", name());
return RespondNow(OneArgument(result.ToValue()));
}
......@@ -247,9 +243,6 @@ FileManagerPrivateSetPreferencesFunction::Run() {
service->SetBoolean(drive::prefs::kDisableDriveOverCellular,
*params->change_info.cellular_disabled);
drive::EventLogger* logger = file_manager::util::GetLogger(profile);
if (logger)
logger->Log(logging::LOG_INFO, "%s succeeded.", name());
return RespondNow(NoArguments());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment