Commit 93ab13df authored by huangs@chromium.org's avatar huangs@chromium.org

Outputting command line if CreateProcess() fails.

Specifically, this is to help us debug Win 8 Aura test flakes.

BUG=

Review URL: https://codereview.chromium.org/289033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271285 0039d316-1c4b-4281-b951-d872f2087c98
parent 6fffd3c1
...@@ -23,6 +23,7 @@ ...@@ -23,6 +23,7 @@
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/process/kill.h" #include "base/process/kill.h"
#include "base/strings/utf_string_conversions.h"
#include "base/sys_info.h" #include "base/sys_info.h"
#include "base/win/object_watcher.h" #include "base/win/object_watcher.h"
#include "base/win/scoped_handle.h" #include "base/win/scoped_handle.h"
...@@ -193,7 +194,8 @@ bool LaunchProcess(const string16& cmdline, ...@@ -193,7 +194,8 @@ bool LaunchProcess(const string16& cmdline,
&temp_process_info); &temp_process_info);
DestroyEnvironmentBlock(enviroment_block); DestroyEnvironmentBlock(enviroment_block);
if (!launched) { if (!launched) {
DPLOG(ERROR); DPLOG(ERROR) << "Command line:" << std::endl << UTF16ToUTF8(cmdline)
<< std::endl;;
return false; return false;
} }
} else { } else {
...@@ -201,7 +203,8 @@ bool LaunchProcess(const string16& cmdline, ...@@ -201,7 +203,8 @@ bool LaunchProcess(const string16& cmdline,
const_cast<wchar_t*>(cmdline.c_str()), NULL, NULL, const_cast<wchar_t*>(cmdline.c_str()), NULL, NULL,
inherit_handles, flags, NULL, NULL, inherit_handles, flags, NULL, NULL,
startup_info, &temp_process_info)) { startup_info, &temp_process_info)) {
DPLOG(ERROR); DPLOG(ERROR) << "Command line:" << std::endl << UTF16ToUTF8(cmdline)
<< std::endl;;
return false; return false;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment