Commit 93cbcb5e authored by Vadym Doroshenko's avatar Vadym Doroshenko Committed by Commit Bot

Remove not needed argument in ProvisionallySave

is_gaia_with_skip_save_password_form is already inside submitted_form.

Bug: 831123
Change-Id: I671cb3d2f1e423ef9128e3c05b8c26805d4c156e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768533Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690396}
parent f80f4b5f
...@@ -638,8 +638,7 @@ void NewPasswordFormManager::OnFetchCompleted() { ...@@ -638,8 +638,7 @@ void NewPasswordFormManager::OnFetchCompleted() {
bool NewPasswordFormManager::ProvisionallySave( bool NewPasswordFormManager::ProvisionallySave(
const FormData& submitted_form, const FormData& submitted_form,
const PasswordManagerDriver* driver, const PasswordManagerDriver* driver) {
bool is_gaia_with_skip_save_password_form) {
DCHECK(DoesManage(submitted_form, driver)); DCHECK(DoesManage(submitted_form, driver));
std::unique_ptr<PasswordForm> parsed_submitted_form = std::unique_ptr<PasswordForm> parsed_submitted_form =
...@@ -654,8 +653,6 @@ bool NewPasswordFormManager::ProvisionallySave( ...@@ -654,8 +653,6 @@ bool NewPasswordFormManager::ProvisionallySave(
return is_submitted_; return is_submitted_;
parsed_submitted_form_ = std::move(parsed_submitted_form); parsed_submitted_form_ = std::move(parsed_submitted_form);
parsed_submitted_form_->form_data.is_gaia_with_skip_save_password_form =
is_gaia_with_skip_save_password_form;
submitted_form_ = submitted_form; submitted_form_ = submitted_form;
is_submitted_ = true; is_submitted_ = true;
CalculateFillingAssistanceMetric(submitted_form); CalculateFillingAssistanceMetric(submitted_form);
......
...@@ -87,11 +87,8 @@ class NewPasswordFormManager : public PasswordFormManagerInterface, ...@@ -87,11 +87,8 @@ class NewPasswordFormManager : public PasswordFormManagerInterface,
// |submitted_form| and |driver|) then saves |submitted_form| to // |submitted_form| and |driver|) then saves |submitted_form| to
// |submitted_form_| field, sets |is_submitted| = true and returns true. // |submitted_form_| field, sets |is_submitted| = true and returns true.
// Otherwise returns false. // Otherwise returns false.
// |is_gaia_with_skip_save_password_form| is true iff this is Gaia form which
// should be skipped on saving.
bool ProvisionallySave(const autofill::FormData& submitted_form, bool ProvisionallySave(const autofill::FormData& submitted_form,
const PasswordManagerDriver* driver, const PasswordManagerDriver* driver);
bool is_gaia_with_skip_save_password_form);
// If |submitted_form| is managed by *this then saves |submitted_form| to // If |submitted_form| is managed by *this then saves |submitted_form| to
// |submitted_form_| field, sets |is_submitted| = true and returns true. // |submitted_form_| field, sets |is_submitted| = true and returns true.
......
...@@ -962,9 +962,7 @@ NewPasswordFormManager* PasswordManager::ProvisionallySaveForm( ...@@ -962,9 +962,7 @@ NewPasswordFormManager* PasswordManager::ProvisionallySaveForm(
return nullptr; return nullptr;
} }
if (!matched_manager->ProvisionallySave( if (!matched_manager->ProvisionallySave(submitted_form, driver))
submitted_form, driver,
submitted_form.is_gaia_with_skip_save_password_form))
return nullptr; return nullptr;
// Set all other form managers to no submission state. // Set all other form managers to no submission state.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment