Commit 93d1a4ce authored by Christopher Grant's avatar Christopher Grant Committed by Commit Bot

Android: Remove original stack decoder wrapper scripts

The generated Android APK helper scripts now support stack decoding
(both explicitly, and indirectly via logcat filtering).  Further, that
new system handles bundles elegantly, unpacking their contents for use
by the stack script.  Hence, this original script should probably be
removed.

See commit 9f0ca133, which wired up the
APK helper scripts originally.

Bug: None
Change-Id: Id18ee6714c35cd9f4a793d348c87a477909e15ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980188
Auto-Submit: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728818}
parent df83dca4
...@@ -840,33 +840,6 @@ template("test_runner_script") { ...@@ -840,33 +840,6 @@ template("test_runner_script") {
} }
} }
template("stack_script") {
generate_wrapper(target_name) {
forward_variables_from(invoker,
[
"deps",
"testonly",
])
_stack_target_name = invoker.stack_target_name
data_deps = [
"//third_party/android_platform/development/scripts:stack_py",
]
if (defined(invoker.data_deps)) {
data_deps += invoker.data_deps
}
executable = "//third_party/android_platform/development/scripts/stack"
wrapper_script = "$root_build_dir/bin/stack_${_stack_target_name}"
executable_args = [
"--output-directory",
"@WrappedPath(.)",
"--arch=$target_cpu",
]
}
}
if (enable_java_templates) { if (enable_java_templates) {
android_sdk_jar = "$android_sdk/android.jar" android_sdk_jar = "$android_sdk/android.jar"
android_default_aapt_path = "$android_sdk_build_tools/aapt" android_default_aapt_path = "$android_sdk_build_tools/aapt"
......
...@@ -3112,15 +3112,6 @@ if (enable_java_templates) { ...@@ -3112,15 +3112,6 @@ if (enable_java_templates) {
} }
} }
if (_native_libs_deps != []) {
_create_stack_script_rule_name = "${_template_name}__stack_script"
_final_deps += [ ":${_create_stack_script_rule_name}" ]
stack_script(_create_stack_script_rule_name) {
stack_target_name = invoker.target_name
deps = _native_libs_deps
}
}
_all_native_libs_deps = _native_libs_deps + _loadable_modules_deps + _all_native_libs_deps = _native_libs_deps + _loadable_modules_deps +
_secondary_abi_native_libs_deps _secondary_abi_native_libs_deps
if (_all_native_libs_deps != []) { if (_all_native_libs_deps != []) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment