Commit 93e63fba authored by Thomas Lukaszewicz's avatar Thomas Lukaszewicz Committed by Commit Bot

Removed diagnostics code from TouchSelectionControllerImpl

Bug: 459423
Change-Id: I33d21c8e23f1544f8ad68a9f58db57a5a3ce1874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216634
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: default avatarMohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773078}
parent cb19cc6e
......@@ -271,14 +271,7 @@ class TouchSelectionControllerImpl::EditingHandleView
}
case ui::ET_GESTURE_SCROLL_END:
case ui::ET_SCROLL_FLING_START: {
// Use a weak pointer to the handle to make sure the handle and its
// owning selection controller is not destroyed by the capture release
// to diagnose a crash on Windows (see crbug.com/459423)
// TODO(mohsen): Delete the diagnostics code when the crash is fixed.
base::WeakPtr<EditingHandleView> weak_ptr =
weak_ptr_factory_.GetWeakPtr();
widget_->ReleaseCapture();
CHECK(weak_ptr);
controller_->SetDraggingHandle(nullptr);
break;
}
......@@ -386,8 +379,6 @@ class TouchSelectionControllerImpl::EditingHandleView
// handle.
bool draw_invisible_;
base::WeakPtrFactory<EditingHandleView> weak_ptr_factory_{this};
DISALLOW_COPY_AND_ASSIGN(EditingHandleView);
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment